[GitHub] [samza] kw2542 commented on a change in pull request #1464: SAMZA-2620: Jackson upgrade 2.12.1

[GitBox <gi...@apache.org>]

kw2542 commented on a change in pull request #1464:
URL: https://github.com/apache/samza/pull/1464#discussion_r581454368



##########
File path: samza-core/src/test/java/org/apache/samza/serializers/model/TestSamzaObjectMapper.java
##########
@@ -165,7 +165,7 @@ public void testDeserializeUnknownTaskModelField() throws IOException {
   /**
    * Given a {@link ContainerModel} JSON with neither a processor-id nor a container-id, deserialization should fail.
    */
-  @Test(expected = SamzaException.class)

Review comment:
       Can you help us understand why the exception type changed?

##########
File path: samza-core/src/main/java/org/apache/samza/clustermanager/container/placement/ContainerPlacementMessageObjectMapper.java
##########
@@ -23,21 +23,16 @@
 import java.util.HashMap;
 import java.util.Map;
 import java.util.UUID;
+import com.fasterxml.jackson.core.JsonGenerator;
+import com.fasterxml.jackson.core.JsonParser;
+import com.fasterxml.jackson.core.ObjectCodec;
+import com.fasterxml.jackson.core.Version;
+import com.fasterxml.jackson.databind.*;

Review comment:
       wildcard import is not allowed in non test sources.

##########
File path: samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java
##########
@@ -19,9 +19,13 @@
 
 package org.apache.samza.serializers.model;
 
-import java.io.IOException;
-import java.util.HashMap;
-import java.util.Map;
+import com.fasterxml.jackson.core.*;

Review comment:
       same




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org