You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Rene Gielen (JIRA)" <ji...@apache.org> on 2013/09/18 09:29:52 UTC

[jira] [Commented] (WW-3905) The TextProvider injection in ActionSupport isn't quite integrated into the framework's core DI

    [ https://issues.apache.org/jira/browse/WW-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13770530#comment-13770530 ] 

Rene Gielen commented on WW-3905:
---------------------------------

Got burned once when I wanted to start refactoring here ;) This is a refactoring we might want to address in Struts NEXT, including possible breaking changes ...
                
> The TextProvider injection in ActionSupport isn't quite integrated into the framework's core DI 
> ------------------------------------------------------------------------------------------------
>
>                 Key: WW-3905
>                 URL: https://issues.apache.org/jira/browse/WW-3905
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Actions
>    Affects Versions: 2.3.4.1
>            Reporter: chad davis
>              Labels: ActionSupport, DependencyInjection, TextProvider
>             Fix For: 2.3.17
>
>
> The injection of the TextProvider into ActionSupport occurs via a lazy initialization in the getTextProvider() method.  This method obtains the TextProvider from a factory that has the implementation injected into it via  the core di mechanism.  The problem with this is that ActionSupport programmatically does the injection using it's reference to the core ContainerImpl.  This makes it impossible to use the Spring plugin's SpringObjectFactory to manage this TextProvider.    

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira