You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "imjyz (via GitHub)" <gi...@apache.org> on 2026/04/29 04:09:38 UTC
[PR] Add client_properties field to Settings for client metadata (#107) [rocketmq-apis]
imjyz opened a new pull request, #108:
URL: https://github.com/apache/rocketmq-apis/pull/108
https://github.com/apache/rocketmq-apis/issues/107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add client_properties field to Settings for client metadata (#107) [rocketmq-apis]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #108:
URL: https://github.com/apache/rocketmq-apis/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add client_properties field to Settings for client metadata (#107) [rocketmq-apis]
Posted by "imjyz (via GitHub)" <gi...@apache.org>.
imjyz commented on code in PR #108:
URL: https://github.com/apache/rocketmq-apis/pull/108#discussion_r3266672939
##########
apache/rocketmq/v2/definition.proto:
##########
@@ -523,6 +530,31 @@ message Settings {
UA user_agent = 7;
Metric metric = 8;
+
+ // Application-defined metadata associated with this client instance.
+ // These properties are for observability, troubleshooting, auditing and
+ // management only.
+ //
+ // Constraints:
+ // - Maximum 32 key-value pairs per client instance
+ // - Key length: 1-64 characters, must match pattern [a-zA-Z][a-zA-Z0-9_.-]*
+ // - Value length: 0-256 characters
+ // - Total serialized size: <= 4KB
+ //
+ // Example keys used by some organizations: app, env, region, zone, version, instance, owner.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add client_properties field to Settings for client metadata (#107) [rocketmq-apis]
Posted by "qianye1001 (via GitHub)" <gi...@apache.org>.
qianye1001 commented on code in PR #108:
URL: https://github.com/apache/rocketmq-apis/pull/108#discussion_r3265165462
##########
apache/rocketmq/v2/definition.proto:
##########
@@ -523,6 +530,31 @@ message Settings {
UA user_agent = 7;
Metric metric = 8;
+
+ // Application-defined metadata associated with this client instance.
+ // These properties are for observability, troubleshooting, auditing and
+ // management only.
+ //
+ // Constraints:
+ // - Maximum 32 key-value pairs per client instance
+ // - Key length: 1-64 characters, must match pattern [a-zA-Z][a-zA-Z0-9_.-]*
+ // - Value length: 0-256 characters
+ // - Total serialized size: <= 4KB
+ //
+ // Example keys used by some organizations: app, env, region, zone, version, instance, owner.
Review Comment:
去掉这里的 // Example keys used by some organizations: app, env, region, zone, version, instance, owner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org