You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Abdelrahman-358 (via GitHub)" <gi...@apache.org> on 2026/03/31 15:51:58 UTC
[PR] Add FROM-first query syntax support [iotdb]
Abdelrahman-358 opened a new pull request, #17410:
URL: https://github.com/apache/iotdb/pull/17410
## Description
### Content1 ...
### Content2 ...
### Content3 ...
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design
(or naming) decision point and compare the alternatives with the designs that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list),
link to that discussion from this PR description and explain what have changed in your final design
compared to your original proposal or the consensus version in the end of the discussion.
If something hasn't changed since the original discussion, you can omit a detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items
apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items
from the checklist above are strictly necessary, but it would be very helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add FROM-first query syntax support [iotdb]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #17410:
URL: https://github.com/apache/iotdb/pull/17410#discussion_r3042394274
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/parser/AstBuilder.java:
##########
@@ -2391,6 +2391,45 @@ public Node visitQuerySpecification(RelationalSqlParser.QuerySpecificationContex
Optional.empty());
}
+ @Override
+ public Node visitFromFirstQuerySpecification(
+ RelationalSqlParser.FromFirstQuerySpecificationContext ctx) {
+ Optional<Relation> from = Optional.empty();
+ List<SelectItem> selectItems = visit(ctx.selectItem(), SelectItem.class);
+
+ List<Relation> relations = visit(ctx.relation(), Relation.class);
+ if (!relations.isEmpty()) {
+ // synthesize implicit join nodes
+ Iterator<Relation> iterator = relations.iterator();
+ Relation relation = iterator.next();
+
+ while (iterator.hasNext()) {
+ relation = new Join(getLocation(ctx), Join.Type.IMPLICIT, relation, iterator.next());
+ }
+
+ from = Optional.of(relation);
+ }
Review Comment:
`visitFromFirstQuerySpecification()` largely duplicates `visitQuerySpecification()` (same implicit-join synthesis and `QuerySpecification` construction). This duplication increases the risk of the two paths diverging behavior over time; consider extracting a shared helper that builds `QuerySpecification` from (relations, optional selectItems, optional WHERE/GROUP BY/HAVING/WINDOW), and have both visitor methods delegate to it.
Also, because `fromFirstQuerySpecification` requires at least one `relation`, the `if (!relations.isEmpty())` branch is effectively redundant here; simplifying to assume non-empty (or asserting) would make the intent clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add FROM-first query syntax support [iotdb]
Posted by "Abdelrahman-358 (via GitHub)" <gi...@apache.org>.
Abdelrahman-358 commented on PR #17410:
URL: https://github.com/apache/iotdb/pull/17410#issuecomment-4188536802
Hi @JackieTien97 , could you please review this PR when you have time?
I’ve also sent a request to the dev mailing list, but it may have been filtered into the Promotions tab.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add FROM-first query syntax support [iotdb]
Posted by "Abdelrahman-358 (via GitHub)" <gi...@apache.org>.
Abdelrahman-358 commented on code in PR #17410:
URL: https://github.com/apache/iotdb/pull/17410#discussion_r3049340810
##########
integration-test/src/test/java/org/apache/iotdb/relational/it/query/recent/IoTDBFromFirstQueryIT.java:
##########
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.relational.it.query.recent;
+
+import org.apache.iotdb.it.env.EnvFactory;
+import org.apache.iotdb.it.framework.IoTDBTestRunner;
+import org.apache.iotdb.itbase.category.TableClusterIT;
+import org.apache.iotdb.itbase.category.TableLocalStandaloneIT;
+
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.runner.RunWith;
+
+import static org.apache.iotdb.db.it.utils.TestUtils.prepareTableData;
+import static org.apache.iotdb.db.it.utils.TestUtils.tableResultSetEqualTest;
+
+@RunWith(IoTDBTestRunner.class)
+@Category({TableLocalStandaloneIT.class, TableClusterIT.class})
+public class IoTDBFromFirstQueryIT {
Review Comment:
Hi @JackieTien97 , Regarding the test for FROM XXX without any other clauses: It fails because, in table mode, when no ORDER BY clause is specified, the query planner doesn't inject a default ordering. The `orderingScheme()` method returns an empty value, causing the distributed planner to use CollectNode rather than MergeSortNode (which would sort the merged results). As a result, the result set is not deterministic.
Would it make sense to introduce a default ordering (by device and time) similar to tree mode, or should we keep the current behavior and require explicit ORDER BY for deterministic results?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add FROM-first query syntax support [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #17410:
URL: https://github.com/apache/iotdb/pull/17410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add FROM-first query syntax support [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 commented on code in PR #17410:
URL: https://github.com/apache/iotdb/pull/17410#discussion_r3042622865
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/parser/AstBuilder.java:
##########
@@ -2391,6 +2391,45 @@ public Node visitQuerySpecification(RelationalSqlParser.QuerySpecificationContex
Optional.empty());
}
+ @Override
+ public Node visitFromFirstQuerySpecification(
Review Comment:
extract all the common codes from `visitQuerySpecification` and `visitFromFirstQuerySpecification` to another private method, the method may need parameters like `(ParserRuleContext parserRuleContext, List<SelectItemContext>, List<RelationContext>, TerminalNode selectNode, SetQuantifierContext, BooleanExpressionContext where, GroupByContext, BooleanExpressionContext having, List<WindowDefinitionContext>)`
##########
integration-test/src/test/java/org/apache/iotdb/relational/it/query/recent/IoTDBFromFirstQueryIT.java:
##########
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.relational.it.query.recent;
+
+import org.apache.iotdb.it.env.EnvFactory;
+import org.apache.iotdb.it.framework.IoTDBTestRunner;
+import org.apache.iotdb.itbase.category.TableClusterIT;
+import org.apache.iotdb.itbase.category.TableLocalStandaloneIT;
+
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.runner.RunWith;
+
+import static org.apache.iotdb.db.it.utils.TestUtils.prepareTableData;
+import static org.apache.iotdb.db.it.utils.TestUtils.tableResultSetEqualTest;
+
+@RunWith(IoTDBTestRunner.class)
+@Category({TableLocalStandaloneIT.class, TableClusterIT.class})
+public class IoTDBFromFirstQueryIT {
Review Comment:
include just `FROM XXX` without any other clauses, by default the resultset is `order by device, time`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org