You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2023/01/09 17:53:49 UTC

[GitHub] [tvm] mehrdadh commented on a diff in pull request #13722: [CI][Docker][Cortex-M]Update ci_cortexm to Ubuntu 20.04 and update nrfjprog version to 10.18.1

mehrdadh commented on code in PR #13722:
URL: https://github.com/apache/tvm/pull/13722#discussion_r1064927027


##########
docker/install/ubuntu_install_nrfjprog.sh:
##########
@@ -21,19 +21,24 @@ set -u
 set -o pipefail
 set -x
 
+TEMP_PATH_NAME="nrfjprog_tmp_path"
+
+# Install JLink
 NRF_COMMANDLINE_TOOLS_FILE=nRFCommandLineToolsLinuxamd64.tar.gz
-NRF_COMMANDLINE_TOOLS_URL=https://nsscprodmedia.blob.core.windows.net/prod/software-and-other-downloads/desktop-software/nrf-command-line-tools/sw/versions-10-x-x/10-12-1/nrfcommandlinetools10121linuxamd64.tar.gz
-NRF_COMMANDLINE_TOOLS_INSTALLER=nRF-Command-Line-Tools_10_12_1_Linux-amd64.deb
-JLINK_LINUX_INSTALLER=JLink_Linux_V688a_x86_64.deb
+NRF_COMMANDLINE_TOOLS_URL=https://nsscprodmedia.blob.core.windows.net/prod/software-and-other-downloads/desktop-software/nrf-command-line-tools/sw/versions-10-x-x/10-18-1/nrf-command-line-tools-10.18.1_linux-amd64.tar.gz

Review Comment:
   I got this file from NRF website and they don't provide any hash based on my understanding
   https://www.nordicsemi.com/Products/Development-tools/nrf-command-line-tools/download
   I'm not sure if there's other way to find a hash for this file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org