You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/07/25 02:39:29 UTC

[GitHub] [incubator-seatunnel] MRYOG opened a new pull request, #2259: [Bug] [root directory] Delete .idea directory #2258

MRYOG opened a new pull request, #2259:
URL: https://github.com/apache/incubator-seatunnel/pull/2259

   delete .idae directory
   
   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] leo65535 commented on pull request #2259: [Bug] [root directory] Delete .idea directory #2258

Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #2259:
URL: https://github.com/apache/incubator-seatunnel/pull/2259#issuecomment-1193495908

   https://github.com/apache/incubator-kyuubi/tree/master/.idea
   https://github.com/apache/flink/tree/master/.idea


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2259: [Bug] [root directory] Delete .idea directory #2258

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2259:
URL: https://github.com/apache/incubator-seatunnel/pull/2259#issuecomment-1193499913

   hi, this is not a bug, if you need context, you can use `gitlog` look .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] MRYOG commented on pull request #2259: [Bug] [root directory] Delete .idea directory #2258

Posted by GitBox <gi...@apache.org>.
MRYOG commented on PR #2259:
URL: https://github.com/apache/incubator-seatunnel/pull/2259#issuecomment-1193501632

   > hi @MRYOG, why need delete the directory? can you explain in detail?
   
   first clone seatunnel project , idea can not find package , like this 
   ![image](https://user-images.githubusercontent.com/10381662/180687745-7e16607a-532c-4cdf-a1bb-1bddbccc8a2e.png)
   If idea normal display package , can delete .idea and local recompile ,I don't think he is very friendly to new users


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] ic4y commented on pull request #2259: [Bug] [root directory] Delete .idea directory #2258

Posted by GitBox <gi...@apache.org>.
ic4y commented on PR #2259:
URL: https://github.com/apache/incubator-seatunnel/pull/2259#issuecomment-1193493339

   cc @CalvinKirs 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] leo65535 commented on pull request #2259: [Bug] [root directory] Delete .idea directory #2258

Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #2259:
URL: https://github.com/apache/incubator-seatunnel/pull/2259#issuecomment-1193508385

   > > hi @MRYOG, why need delete the directory? can you explain in detail?
   > 
   > first clone seatunnel project , idea can not find package , like this ![image](https://user-images.githubusercontent.com/10381662/180687745-7e16607a-532c-4cdf-a1bb-1bddbccc8a2e.png) If idea normal display package , can delete .idea and local recompile ,I don't think it is very friendly to new users
   
   hi @MRYOG, the `vcs.xml` will not affect ide import SeaTunnel project, you should clean the idea cache.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] leo65535 commented on pull request #2259: [Bug] [root directory] Delete .idea directory #2258

Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #2259:
URL: https://github.com/apache/incubator-seatunnel/pull/2259#issuecomment-1193493933

   hi @MRYOG, why need delete the directory? can you explain in detail?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] MRYOG commented on pull request #2259: [Bug] [root directory] Delete .idea directory #2258

Posted by GitBox <gi...@apache.org>.
MRYOG commented on PR #2259:
URL: https://github.com/apache/incubator-seatunnel/pull/2259#issuecomment-1193510512

   > hi, this is not a bug, if you need context, you can use `gitlog` look .
   
   ok, but i think this is a open source project , the directory of a compiler should not appear 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] CalvinKirs closed pull request #2259: [Bug] [root directory] Delete .idea directory #2258

Posted by GitBox <gi...@apache.org>.
CalvinKirs closed pull request #2259: [Bug] [root directory] Delete .idea directory #2258
URL: https://github.com/apache/incubator-seatunnel/pull/2259


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org