[GitHub] [incubator-skywalking] BFergerson commented on issue #2386: Vert.x Core 3.x Plugin

[GitBox <gi...@apache.org>]

BFergerson commented on issue #2386: Vert.x Core 3.x Plugin
URL: https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-474650413
 
 
   @wu-sheng, luck you :P. That's okay though. I'm sure this isn't ready yet. I wanted to ask you if I was doing the `EntrySpan`/`ExitSpan` pattern correctly for the event bus.
   
   Basically, when you send a message through the event bus it could be going to another computer or it could be going to a consumer on the same computer. So there is a chance that it could be a message which is sent on the same thread, cross-thread, or cross process. My question is:
    - should I be detecting if the message was same thread, cross thread, or cross-process and build the appropriate span based on that?
   
   Should I have logic like:
   ```
   If it was sent cross-thread:
    - Ignore ContextCarrier and work with ContextSnapshot
   
   If it was sent cross-process
    - Use ContextCarrier
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services