You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Arun C Murthy (JIRA)" <ji...@apache.org> on 2012/07/10 15:18:36 UTC
[jira] [Created] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH needs
a documented default value in YarnConfiguration
Arun C Murthy created MAPREDUCE-4422:
----------------------------------------
Summary: YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
Key: MAPREDUCE-4422
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
Project: Hadoop Map/Reduce
Issue Type: Improvement
Reporter: Arun C Murthy
MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
However, we didn't add a default value to YarnConfiguration, as-is the norm.
Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH needs
a documented default value in YarnConfiguration
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4422:
-------------------------------
Resolution: Fixed
Fix Version/s: 2.0.1-alpha
Target Version/s: (was: 2.0.1-alpha)
Status: Resolved (was: Patch Available)
Committed to branch-2 and trunk. Thanks Ahmed!
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413622#comment-13413622 ]
Hudson commented on MAPREDUCE-4422:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2482 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2482/])
Reverting MAPREDUCE-4422 from trunk until all comments are addressed (Revision 1361107)
Result = FAILURE
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361107
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413088#comment-13413088 ]
Harsh J commented on MAPREDUCE-4422:
------------------------------------
Thanks Ahmed. +1, pending Jenkins.
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH needs a
documented default value in YarnConfiguration
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy closed MAPREDUCE-4422.
------------------------------------
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.2-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev4.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413565#comment-13413565 ]
Hudson commented on MAPREDUCE-4422:
-----------------------------------
Integrated in Hadoop-Common-trunk-Commit #2461 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2461/])
MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. Contributed by Ahmed Radwan. (harsh) (Revision 1361061)
Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361061
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416749#comment-13416749 ]
Hudson commented on MAPREDUCE-4422:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2556 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2556/])
MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. (ahmed via tucu) (Revision 1362722)
Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362722
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.2.0-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev4.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413092#comment-13413092 ]
Hadoop QA commented on MAPREDUCE-4422:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12536259/MAPREDUCE-4422_rev2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2581//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2581//console
This message is automatically generated.
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413603#comment-13413603 ]
Hudson commented on MAPREDUCE-4422:
-----------------------------------
Integrated in Hadoop-Common-trunk-Commit #2462 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2462/])
Reverting MAPREDUCE-4422 from trunk until all comments are addressed (Revision 1361107)
Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361107
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH needs
a documented default value in YarnConfiguration
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated MAPREDUCE-4422:
------------------------------------------
Resolution: Fixed
Fix Version/s: (was: 2.1.0-alpha)
2.2.0-alpha
Status: Resolved (was: Patch Available)
Thanks Ahmed. Committed to trunk and branch-2
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.2.0-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev4.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH needs
a documented default value in YarnConfiguration
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated MAPREDUCE-4422:
------------------------------------
Attachment: MAPREDUCE-4422_rev3.patch
Thanks Arun and Harsh, Here is the updated patch with Arun comments addressed. I have also spotted another use in distributedshell client that could be updated and I added that to the patch.
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412693#comment-13412693 ]
Harsh J commented on MAPREDUCE-4422:
------------------------------------
The yarn-default contains spaces, but am guessing that those missing here is no big deal?:
{code}
$HADOOP_CONF_DIR, $HADOOP_COMMON_HOME/share/hadoop/common/*, $HADOOP_COMMON_HOME/share/hadoop/common/lib/*, $HADOOP_HDFS_HOME/share/hadoop/hdfs/*, $HADOOP_HDFS_HOME/share/hadoop/hdfs/lib/*, $YARN_HOME/share/hadoop/mapreduce/*, $YARN_HOME/share/hadoop/mapreduce/lib/*
{code}
Regardless of the result, lets make it consistent in both places. I feel its better to do that with an area like the CP config.
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-4422.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH needs
a documented default value in YarnConfiguration
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan reassigned MAPREDUCE-4422:
---------------------------------------
Assignee: Ahmed Radwan
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH needs
a documented default value in YarnConfiguration
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated MAPREDUCE-4422:
------------------------------------
Attachment: MAPREDUCE-4422_rev4.patch
Nice NIT! Thanks Tucu. Here is the updated patch.
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev4.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH needs
a documented default value in YarnConfiguration
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated MAPREDUCE-4422:
------------------------------------
Status: Patch Available (was: Reopened)
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev4.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412633#comment-13412633 ]
Ahmed Radwan commented on MAPREDUCE-4422:
-----------------------------------------
Here is the patch adding the default value (from yarn-default.xml) to YarnConfiguration as well. Sorry, I missed adding it while working on MAPREDUCE-3505.
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-4422.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH needs
a documented default value in YarnConfiguration
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated MAPREDUCE-4422:
------------------------------------
Status: Patch Available (was: Open)
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-4422.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH needs
a documented default value in YarnConfiguration
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated MAPREDUCE-4422:
------------------------------------
Attachment: MAPREDUCE-4422_rev2.patch
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH needs
a documented default value in YarnConfiguration
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4422:
-------------------------------
Attachment: MAPREDUCE-4422_rev3.patch
Here's a patch with Arun's comments specifically addressed.
Arun/Ahmed - Are there other spots and/or tests we should be using this default string at?
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413665#comment-13413665 ]
Hudson commented on MAPREDUCE-4422:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk #1102 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1102/])
Reverting MAPREDUCE-4422 from trunk until all comments are addressed (Revision 1361107)
MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. Contributed by Ahmed Radwan. (harsh) (Revision 1361061)
Result = FAILURE
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361107
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361061
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416743#comment-13416743 ]
Hudson commented on MAPREDUCE-4422:
-----------------------------------
Integrated in Hadoop-Common-trunk-Commit #2491 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2491/])
MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. (ahmed via tucu) (Revision 1362722)
Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362722
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.2.0-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev4.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417008#comment-13417008 ]
Hudson commented on MAPREDUCE-4422:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk #1107 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1107/])
MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. (ahmed via tucu) (Revision 1362722)
Result = FAILURE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362722
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.2.0-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev4.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413563#comment-13413563 ]
Hudson commented on MAPREDUCE-4422:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2527 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2527/])
MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. Contributed by Ahmed Radwan. (harsh) (Revision 1361061)
Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361061
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413073#comment-13413073 ]
Ahmed Radwan commented on MAPREDUCE-4422:
-----------------------------------------
Thanks Harsh for the review!
Yes, it is not an issue, but I agree about consistency. I have updated the patch accordingly.
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413751#comment-13413751 ]
Arun C Murthy commented on MAPREDUCE-4422:
------------------------------------------
bq. Or do you just mean modifying the call to be conf.get(YarnConfiguration.YARN_APPLICATION_CLASSPATH, DEFAULT_YARN_APPLICATION_CLASSPATH),
Ahmed - yes. Apologies if I wasn't clear, that was what I meant.
bq. which will not make a difference in this case as the default is already picked if the property is not set.
Ahmed - the point of doing this is essentially documentation. We follow the convention all over the codebase so that developers quickly grok the flow; and hence the jira itself.
bq. Configuration.getString uses StringTokenizer to achieve exactly what String.split will do here. I am not sure if one is more efficient than the other,
Ahmed - the idea behind adding Configuration.getStrings was to re-use existing apis rather than hand-craft it for modularity/reuse, not efficiency. As you can see, we use it in a number of places all over the codebase for similar scenarios to parse comma-delimited values.
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH needs
a documented default value in YarnConfiguration
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4422:
-------------------------------
Component/s: nodemanager
Target Version/s: 2.0.1-alpha
Affects Version/s: 2.0.0-alpha
Hadoop Flags: Reviewed
Committing shortly.
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413970#comment-13413970 ]
Ahmed Radwan commented on MAPREDUCE-4422:
-----------------------------------------
Thanks Arun for the clarifications! I have already submitted a new patch yesterday incorporating your comments. Please let me know if you have any other comments.
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412644#comment-13412644 ]
Hadoop QA commented on MAPREDUCE-4422:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12536196/MAPREDUCE-4422.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2578//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2578//console
This message is automatically generated.
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-4422.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH needs
a documented default value in YarnConfiguration
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated MAPREDUCE-4422:
------------------------------------
Attachment: MAPREDUCE-4422.patch
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Attachments: MAPREDUCE-4422.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414225#comment-13414225 ]
Hadoop QA commented on MAPREDUCE-4422:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12536485/MAPREDUCE-4422_rev4.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2591//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2591//console
This message is automatically generated.
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev4.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413593#comment-13413593 ]
Harsh J commented on MAPREDUCE-4422:
------------------------------------
/me facepalms at not seeing that. Sorry.
I have reverted MAPREDUCE-4422 from both branch-2 and trunk, for until
your comments are all addressed.
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413755#comment-13413755 ]
Hudson commented on MAPREDUCE-4422:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #1135 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1135/])
Reverting MAPREDUCE-4422 from trunk until all comments are addressed (Revision 1361107)
MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. Contributed by Ahmed Radwan. (harsh) (Revision 1361061)
Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361107
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361061
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414145#comment-13414145 ]
Alejandro Abdelnur commented on MAPREDUCE-4422:
-----------------------------------------------
Ahmed, one NIT I see: The default value should be a String[], doing the "....".split() in teh constant definition. Then when using it as default value there is not split() call over and over.
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417101#comment-13417101 ]
Hudson commented on MAPREDUCE-4422:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #1140 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1140/])
MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. (ahmed via tucu) (Revision 1362722)
Result = FAILURE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362722
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.2.0-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev4.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH needs
a documented default value in YarnConfiguration
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy reopened MAPREDUCE-4422:
--------------------------------------
Uh, Harsh/Ahmed, I'm confused... the newly added variable DEFAULT_YARN_APPLICATION_CLASSPATH isn't being used anywhere? The point of adding this was to use it, at least, in MRApps.setMRFrameworkClasspath?
Also, not sure whether this was introduced via MAPREDUCE-3505, but we should use Configuration.getStrings rather than do a 'manual' String.split to parse this out.
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413601#comment-13413601 ]
Hudson commented on MAPREDUCE-4422:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2528 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2528/])
Reverting MAPREDUCE-4422 from trunk until all comments are addressed (Revision 1361107)
Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361107
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413594#comment-13413594 ]
Ahmed Radwan commented on MAPREDUCE-4422:
-----------------------------------------
> the newly added variable DEFAULT_YARN_APPLICATION_CLASSPATH isn't being used anywhere? The point of adding this was to use it, at least, in MRApps.setMRFrameworkClasspath?
MRApps.setMRFrameworkClasspath reads the value from the conf files through conf.get(YarnConfiguration.YARN_APPLICATION_CLASSPATH), and if not set, the default value will be picked from yarn-default.xml. Making it reads the DEFAULT_YARN_APPLICATION_CLASSPATH will defeat the purpose of having it configurable. Or do you just mean modifying the call to be conf.get(YarnConfiguration.YARN_APPLICATION_CLASSPATH, DEFAULT_YARN_APPLICATION_CLASSPATH), which will not make a difference in this case as the default is already picked if the property is not set.
> we should use Configuration.getStrings rather than do a 'manual' String.split to parse this out.
Configuration.getString uses StringTokenizer to achieve exactly what String.split will do here. I am not sure if one is more efficient than the other, but I can change the it if you know it is better. I'll upload a new patch with the updates.
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413595#comment-13413595 ]
Hudson commented on MAPREDUCE-4422:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2481 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2481/])
MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. Contributed by Ahmed Radwan. (harsh) (Revision 1361061)
Result = FAILURE
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361061
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416710#comment-13416710 ]
Alejandro Abdelnur commented on MAPREDUCE-4422:
-----------------------------------------------
+1
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.1.0-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev4.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH
needs a documented default value in YarnConfiguration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416768#comment-13416768 ]
Hudson commented on MAPREDUCE-4422:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2512 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2512/])
MAPREDUCE-4422. YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration. (ahmed via tucu) (Revision 1362722)
Result = FAILURE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362722
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.2.0-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev4.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira