You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by sharad agarwal <sh...@apache.org> on 2015/05/28 11:53:12 UTC
Review Request 34761: Lens 581: Revisit ML API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34761/
-----------------------------------------------------------
Review request for lens.
Repository: lens
Description
-------
New ML API
Diffs
-----
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/sdk/Algorithm.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/sdk/MLDriver.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/algo/sdk/TrainedModel.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Algo.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/AlgoParam.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Evaluation.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Feature.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/LensML.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Model.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/ModelInstance.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Prediction.java PRE-CREATION
lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Status.java PRE-CREATION
Diff: https://reviews.apache.org/r/34761/diff/
Testing
-------
Thanks,
sharad agarwal
Re: Review Request 34761: Lens 581: Revisit ML API
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34761/#review87892
-----------------------------------------------------------
Ship it!
Ship It!
- Jaideep dhok
On May 28, 2015, 9:53 a.m., sharad agarwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34761/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 9:53 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> New ML API
>
>
> Diffs
> -----
>
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/sdk/Algorithm.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/sdk/MLDriver.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/sdk/TrainedModel.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Algo.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/AlgoParam.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Evaluation.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Feature.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/LensML.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Model.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/ModelInstance.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Prediction.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Status.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34761/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> sharad agarwal
>
>
Re: Review Request 34761: Lens 581: Revisit ML API
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34761/#review87903
-----------------------------------------------------------
lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Evaluation.java
<https://reviews.apache.org/r/34761/#comment140316>
Can we make the variable private and add @Data from lombak, if getters and setters are required?
Same holds for classes : Feature, Model, ModelInstance and Prediction
lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/LensML.java
<https://reviews.apache.org/r/34761/#comment140315>
There might be checkstyle errors because of whitespace characters. Can you run mvn clean install and update?
- Amareshwari Sriramadasu
On May 28, 2015, 9:53 a.m., sharad agarwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34761/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 9:53 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> New ML API
>
>
> Diffs
> -----
>
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/sdk/Algorithm.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/sdk/MLDriver.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/algo/sdk/TrainedModel.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Algo.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/AlgoParam.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Evaluation.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Feature.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/LensML.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Model.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/ModelInstance.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Prediction.java PRE-CREATION
> lens-ml-lib/src/main/java/org/apache/lens/ml/apinew/Status.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34761/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> sharad agarwal
>
>