[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #4764: [Bug] Do not push down limit operation when ODBC table do not push all conjunct as filter.

[GitBox <gi...@apache.org>]

wuyunfeng commented on a change in pull request #4764:
URL: https://github.com/apache/incubator-doris/pull/4764#discussion_r507641441



##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/OdbcScanNode.java
##########
@@ -114,16 +114,22 @@ protected String getNodeExplainString(String prefix, TExplainLevel detailLevel)
         return output.toString();
     }
 
+    // only all conjuncts be pushed down as filter, we can
+    // push down limit operation to ODBC table
+    private boolean needPushDownLimit() {

Review comment:
       ```suggestion
       private boolean canLimitPushDown() {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org