You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bruce Lowekamp (JIRA)" <ji...@apache.org> on 2010/08/19 18:51:18 UTC

[jira] Created: (THRIFT-859) Allow py:twisted to be generated in different namespace than py

Allow py:twisted to be generated in different namespace than py
---------------------------------------------------------------

                 Key: THRIFT-859
                 URL: https://issues.apache.org/jira/browse/THRIFT-859
             Project: Thrift
          Issue Type: New Feature
          Components: Compiler (Python)
    Affects Versions: 0.4
            Reporter: Bruce Lowekamp


This patch allows a 

namespace py foo
namespace py.twisted bar

to be specified that will cause non-twisted and twisted python to be generated into different namespaces.

It also reverts a check in t_program.h that prevented this type of namespace declaration from being made (see issue THRIFT-857)


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (THRIFT-859) Allow py:twisted to be generated in different namespace than py

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-859.
--------------------------------

         Assignee: Bruce Lowekamp
    Fix Version/s: 0.5
       Resolution: Fixed

I just committed this.

> Allow py:twisted to be generated in different namespace than py
> ---------------------------------------------------------------
>
>                 Key: THRIFT-859
>                 URL: https://issues.apache.org/jira/browse/THRIFT-859
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Python - Compiler
>    Affects Versions: 0.4
>            Reporter: Bruce Lowekamp
>            Assignee: Bruce Lowekamp
>             Fix For: 0.5
>
>         Attachments: py-twisted-namespace.patch
>
>
> This patch allows a 
> namespace py foo
> namespace py.twisted bar
> to be specified that will cause non-twisted and twisted python to be generated into different namespaces.
> It also reverts a check in t_program.h that prevented this type of namespace declaration from being made (see issue THRIFT-857)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-859) Allow py:twisted to be generated in different namespace than py

Posted by "Bruce Lowekamp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce Lowekamp updated THRIFT-859:
----------------------------------

    Attachment: py-twisted-namespace.patch

This patch implements only the python functionality, relative to a patch just submitted for THRIFT-857.

> Allow py:twisted to be generated in different namespace than py
> ---------------------------------------------------------------
>
>                 Key: THRIFT-859
>                 URL: https://issues.apache.org/jira/browse/THRIFT-859
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Compiler (Python)
>    Affects Versions: 0.4
>            Reporter: Bruce Lowekamp
>         Attachments: py-twisted-namespace.patch
>
>
> This patch allows a 
> namespace py foo
> namespace py.twisted bar
> to be specified that will cause non-twisted and twisted python to be generated into different namespaces.
> It also reverts a check in t_program.h that prevented this type of namespace declaration from being made (see issue THRIFT-857)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-859) Allow py:twisted to be generated in different namespace than py

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900457#action_12900457 ] 

Bryan Duxbury commented on THRIFT-859:
--------------------------------------

I'd prefer if this patch didn't revert other changes. It hasn't been decided what exactly we'll be doing in THRIFT-857.

> Allow py:twisted to be generated in different namespace than py
> ---------------------------------------------------------------
>
>                 Key: THRIFT-859
>                 URL: https://issues.apache.org/jira/browse/THRIFT-859
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Compiler (Python)
>    Affects Versions: 0.4
>            Reporter: Bruce Lowekamp
>         Attachments: py-twisted-namespace.patch
>
>
> This patch allows a 
> namespace py foo
> namespace py.twisted bar
> to be specified that will cause non-twisted and twisted python to be generated into different namespaces.
> It also reverts a check in t_program.h that prevented this type of namespace declaration from being made (see issue THRIFT-857)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-859) Allow py:twisted to be generated in different namespace than py

Posted by "Bruce Lowekamp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce Lowekamp updated THRIFT-859:
----------------------------------

    Attachment: py-twisted-namespace.patch

> Allow py:twisted to be generated in different namespace than py
> ---------------------------------------------------------------
>
>                 Key: THRIFT-859
>                 URL: https://issues.apache.org/jira/browse/THRIFT-859
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Compiler (Python)
>    Affects Versions: 0.4
>            Reporter: Bruce Lowekamp
>         Attachments: py-twisted-namespace.patch
>
>
> This patch allows a 
> namespace py foo
> namespace py.twisted bar
> to be specified that will cause non-twisted and twisted python to be generated into different namespaces.
> It also reverts a check in t_program.h that prevented this type of namespace declaration from being made (see issue THRIFT-857)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-859) Allow py:twisted to be generated in different namespace than py

Posted by "Bruce Lowekamp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce Lowekamp updated THRIFT-859:
----------------------------------

    Attachment:     (was: py-twisted-namespace.patch)

> Allow py:twisted to be generated in different namespace than py
> ---------------------------------------------------------------
>
>                 Key: THRIFT-859
>                 URL: https://issues.apache.org/jira/browse/THRIFT-859
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Compiler (Python)
>    Affects Versions: 0.4
>            Reporter: Bruce Lowekamp
>         Attachments: py-twisted-namespace.patch
>
>
> This patch allows a 
> namespace py foo
> namespace py.twisted bar
> to be specified that will cause non-twisted and twisted python to be generated into different namespaces.
> It also reverts a check in t_program.h that prevented this type of namespace declaration from being made (see issue THRIFT-857)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.