[jira] [Commented] (SOLR-7557) Solrj doesn't handle child documents when using queryAndStreamResponse

["Marvin Bredal Lillehaug (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-7557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653041#comment-16653041 ] 

Marvin Bredal Lillehaug commented on SOLR-7557:
-----------------------------------------------

We have been running with a version of 7.4.0 with this change since my last comment, and this does work. 

Could anyone give some feedback and merge if no other solutions are suggested?

> Solrj doesn't handle child documents when using queryAndStreamResponse
> ----------------------------------------------------------------------
>
>                 Key: SOLR-7557
>                 URL: https://issues.apache.org/jira/browse/SOLR-7557
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrJ
>    Affects Versions: 5.4
>            Reporter: Stian Østerhaug
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Getting the results from a query that as child documents results in "parsing error" when using SolrClient's queryAndStreamResponse(), but not when using the regular query() method.
> The bug is caused by StreamingBinaryResponseParser's JavaBinCodec override of readSolrDocument which always returns null (the document is instead passed to the callback), but JavaBinCodec uses the method to also decode child documents.
> I have fixed this by using a simple nestedLevel variable that can be used to detect if the document being parsed is a child (and should be returned) or a parent (and should be passed to the callback).
> The fix feels kinda hacky, but it is simple. Link to a Github pull request to follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org