You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/31 11:31:03 UTC

[GitHub] [airflow] kanga333 edited a comment on pull request #9444: Add placement_strategy option

kanga333 edited a comment on pull request #9444:
URL: https://github.com/apache/airflow/pull/9444#issuecomment-660088688


   Thanks for your review.  I think I've added unit tests. 
   
   In the test, I set a new option to ECS operator and run it. And I'm making sure the options are set up correctly in the mock. 
   https://github.com/apache/airflow/pull/9444/files#diff-d5b4e15516001a0aa1fc8f7e6f2ebef6R129
   https://github.com/apache/airflow/pull/9444/files#diff-d5b4e15516001a0aa1fc8f7e6f2ebef6R161
   
   Other options have been tested in a similar way. Should I add a test case?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org