You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/08/16 09:06:09 UTC
[PR] Refactor Firebird result row building and BLOB reads [shardingsphere]
terrymanu opened a new pull request, #39484:
URL: https://github.com/apache/shardingsphere/pull/39484
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Firebird result row building and BLOB reads [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39484:
URL: https://github.com/apache/shardingsphere/pull/39484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Firebird result row building and BLOB reads [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39484:
URL: https://github.com/apache/shardingsphere/pull/39484#issuecomment-5306688555
### Result
**Review Result: Mergeable**
The latest public head of PR #39484, `2eb665ca77b96c768685e0babe8a55580efcad02`, has passed the code-correctness review. No blocking issue met the Finding Proof Gate.
### Evidence
- Execute and Fetch now share `FirebirdBinaryRowBuilder`, preserving cell order, JDBC type mapping, and original data references: [builder](https://github.com/apache/shardingsphere/blob/2eb665ca77b96c768685e0babe8a55580efcad02/proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/statement/FirebirdBinaryRowBuilder.java#L43-L48).
- `FirebirdBlobReadCache.readSegment` keeps the original array with an offset, copies only the returned segment, and removes the cursor when complete: [cache](https://github.com/apache/shardingsphere/blob/2eb665ca77b96c768685e0babe8a55580efcad02/proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/blob/cache/FirebirdBlobReadCache.java#L86-L99).
- Get BLOB segment preserves EOF, PARTIAL, and COMPLETE states as well as the existing length limits: [executor](https://github.com/apache/shardingsphere/blob/2eb665ca77b96c768685e0babe8a55580efcad02/proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/blob/FirebirdGetBlobSegmentCommandExecutor.java#L60-L74).
- BLOB info uses the cursor’s remaining length and retains the write-cache fallback: [info executor](https://github.com/apache/shardingsphere/blob/2eb665ca77b96c768685e0babe8a55580efcad02/proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/info/FirebirdBlobInfoExecutor.java#L50-L57).
- Tests cover row construction, empty and missing BLOBs, zero-length requests, partial and complete reads, consecutive reads, cursor isolation, and length fallback: [changed test files](https://github.com/apache/shardingsphere/pull/39484/files).
### Coverage
- Review range: base `228e98b3274695c14a2c07f76459c76943403099` through head `2eb665ca77b96c768685e0babe8a55580efcad02`.
- The authoritative GitHub file list contains 10 files and matches the local triple-dot file list.
- The row-building, BLOB-cursor, and protocol-consumer behavior clusters completed root-cause, blast-radius, tests/runtime, and convergence review.
- Local verification: 43/43 focused tests passed; 263/263 Firebird module tests passed; affected production classes reached 100% class, line, and branch coverage.
- This is a Code Correctness Review and therefore assesses code-scope readiness only; GitHub Actions and CI status were not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org