[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #527: [SpotBugs] Fix REC_CATCH_EXCEPTION

["kaijchen (via GitHub)" <gi...@apache.org>]

kaijchen commented on code in PR #527:
URL: https://github.com/apache/incubator-uniffle/pull/527#discussion_r1091830274


##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -528,7 +529,7 @@ private Roaring64NavigableMap getExpectedTasksByExecutorId(
                   endMapIndex,
                   startPartition,
                   endPartition);
-    } catch (Exception ignored) {
+    } catch (NoSuchMethodException | InvocationTargetException | IllegalAccessException ignored1) {

Review Comment:
   I believe some RuntimeException such as NPE should not be catched.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org