[GitHub] [arrow-datafusion] tz70s commented on a diff in pull request #6232: Safeguard round function decimal places overflow

["tz70s (via GitHub)" <gi...@apache.org>]

tz70s commented on code in PR #6232:
URL: https://github.com/apache/arrow-datafusion/pull/6232#discussion_r1226999164


##########
datafusion/physical-expr/src/math_expressions.rs:
##########
@@ -290,6 +295,14 @@ pub fn round(args: &[ArrayRef]) -> Result<ArrayRef> {
     }
 }
 
+fn round_downcast_decimal_places(decimal_place: i64) -> Result<i32> {

Review Comment:
   Thanks, I made it as a macro instead!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org