You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "kenhuuu (via GitHub)" <gi...@apache.org> on 2023/02/28 01:45:24 UTC
[GitHub] [tinkerpop] kenhuuu opened a new pull request, #1983: TINKERPOP-2526 Add imports to the Console via an ImportCustomizer.
kenhuuu opened a new pull request, #1983:
URL: https://github.com/apache/tinkerpop/pull/1983
Adding imports by providing the CompilerConfiguration with an ImportCustomizer greatly improves performance because the imports won't be resolved again for each complete line in a script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #1983: TINKERPOP-2526 Add imports to the Console via an ImportCustomizer.
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #1983:
URL: https://github.com/apache/tinkerpop/pull/1983#issuecomment-1447583559
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1983: TINKERPOP-2526 Add imports to the Console via an ImportCustomizer.
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette commented on PR #1983:
URL: https://github.com/apache/tinkerpop/pull/1983#issuecomment-1450678996
wow - hard to believe this was the fix all this time. incredible job getting to the bottom of this and working with the Groovy Community to help solve it. this fix unlocks a lot of blockages. hero! 🏅
needs a CHANGELOG entry, but other than that:
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer commented on pull request #1983: TINKERPOP-2526 Add imports to the Console via an ImportCustomizer.
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #1983:
URL: https://github.com/apache/tinkerpop/pull/1983#issuecomment-1448757832
Previously building the docs was impossibly slow on any groovy version beyond 2.5.15. What is the doc building performance on newer versions of groovy with these changes included?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu commented on pull request #1983: TINKERPOP-2526 Add imports to the Console via an ImportCustomizer.
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #1983:
URL: https://github.com/apache/tinkerpop/pull/1983#issuecomment-1450895996
> Previously building the docs was impossibly slow on any groovy version beyond 2.5.15. What is the doc building performance on newer versions of groovy with these changes included?
With these changes and Groovy 2.5.17 (a version we noticed a slowdown with), the 3.5.5 documentation processing took roughly 25 min. The 3.5.5 release code takes about 90m to do the same documentation processing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu commented on pull request #1983: TINKERPOP-2526 Add imports to the Console via an ImportCustomizer.
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #1983:
URL: https://github.com/apache/tinkerpop/pull/1983#issuecomment-1452625213
VOTE + 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu merged pull request #1983: TINKERPOP-2526 Add imports to the Console via an ImportCustomizer.
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu merged PR #1983:
URL: https://github.com/apache/tinkerpop/pull/1983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org