You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/08 05:24:39 UTC

[GitHub] [beam] kmjung commented on a change in pull request #11580: [BEAM-9861] Reject fractional values outside of (0.0, 1.0)

kmjung commented on a change in pull request #11580:
URL: https://github.com/apache/beam/pull/11580#discussion_r421945047



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java
##########
@@ -288,6 +288,11 @@ public synchronized void close() {
           source.stream.getName(),
           fraction);
 
+      if (fraction <= 0.0 || fraction >= 1.0) {
+        LOG.info("BigQuery Storage API does not support splitting at fraction {}", fraction);

Review comment:
       The observed value was 1.0.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org