You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2017/05/22 19:30:58 UTC
[GitHub] nifi pull request #1838: NIFI-3933: Monitor heartbeats based on connected no...
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1838
NIFI-3933: Monitor heartbeats based on connected nodes
NIFI-3933:
- When monitoring heartbeats use the connected nodes as the basis for the check. This addresses the case when a node is terminated and no corresponding heartbeats exist.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-3933
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1838.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1838
----
commit 4a4e0159b6d6b81f895d43c4ed95a5d8ac9a329e
Author: Matt Gilman <ma...@gmail.com>
Date: 2017-05-22T19:28:30Z
NIFI-3933:
- When monitoring heartbeats use the connected nodes as the basis for the check. This addresses the case when a node is terminated and no corresponding heartbeats exist.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1838: NIFI-3933: Monitor heartbeats based on connected nodes
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1838
+1 all looks good. Was able to verify behavior. Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1838: NIFI-3933: Monitor heartbeats based on connected no...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1838#discussion_r117835377
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/coordination/heartbeat/HeartbeatMonitor.java ---
@@ -59,6 +59,13 @@
void purgeHeartbeats();
/**
+ * Returns when the heartbeats were purged last.
+ *
+ * @return when the heartbeats were purged last
+ */
+ long getPurgeTimestamp();
--- End diff --
This feels a bit odd to add to HeartbeatMonitor. I think this is a function of the specific implementation of AbstractHeartbeatMonitor. I think this should instead be an abstract method on the AbstractHeartbeatMonitor instead of going into this interface.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1838: NIFI-3933: Monitor heartbeats based on connected no...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1838
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---