You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Deepika0510 (via GitHub)" <gi...@apache.org> on 2023/06/24 19:22:29 UTC
[GitHub] [lucene] Deepika0510 commented on a diff in pull request #12345: LUCENE-10641: IndexSearcher#setTimeout should also abort query rewrites, point ranges and vector searches
Deepika0510 commented on code in PR #12345:
URL: https://github.com/apache/lucene/pull/12345#discussion_r1240925257
##########
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##########
@@ -763,6 +763,11 @@ public Query rewrite(Query original) throws IOException {
for (Query rewrittenQuery = query.rewrite(this);
rewrittenQuery != query;
rewrittenQuery = query.rewrite(this)) {
+ if (queryTimeout != null) {
Review Comment:
Thank you @mikemccand and @jpountz!
@jpountz I didn't get the idea behind wrapping `Directory` here. The rewrite method produce a more efficient query for search, I wonder how it is related to `Directory` class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org