You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/06/25 15:24:03 UTC

[GitHub] [kvrocks] tisonkun commented on a diff in pull request #1516: (deps) Bump rocksdb v8.3.2

tisonkun commented on code in PR #1516:
URL: https://github.com/apache/kvrocks/pull/1516#discussion_r1241220394


##########
x.py:
##########
@@ -106,7 +106,7 @@ def build(dir: str, jobs: Optional[int], ghproxy: bool, ninja: bool, unittest: b
 
     makedirs(dir, exist_ok=True)
 
-    cmake_options = ["-DCMAKE_BUILD_TYPE=RelWithDebInfo"]
+    cmake_options = ["-DCMAKE_BUILD_TYPE=RelWithDebInfo", "-DPORTABLE=0"]

Review Comment:
   Do we report this case to the upstream? I'm OK with this patch but we should at least report the inconvenience for possible improvement from upstream.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org