You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/26 09:25:10 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request, #20562: Reduce foreach call times and object create times
strongduanmu opened a new pull request, #20562:
URL: https://github.com/apache/shardingsphere/pull/20562
Ref #20531.
Changes proposed in this pull request:
- use Map instead of Collection to optimize processUnits call performance
- move processStatements foreach to ExecuteProcessContext
- use ExecuteProcessContext instead of YamlExecuteProcessContext in ShowProcessListManager
- remove useless logic for report method after sql units execute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20562: Reduce foreach call times and object create times
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20562:
URL: https://github.com/apache/shardingsphere/pull/20562#issuecomment-1228389203
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20562?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20562](https://codecov.io/gh/apache/shardingsphere/pull/20562?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e82bd37) into [master](https://codecov.io/gh/apache/shardingsphere/commit/12a6e92e6e8585770e0861614f79da6d2fd9826a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (12a6e92) will **decrease** coverage by `0.00%`.
> The diff coverage is `28.98%`.
```diff
@@ Coverage Diff @@
## master #20562 +/- ##
============================================
- Coverage 60.91% 60.91% -0.01%
- Complexity 2415 2416 +1
============================================
Files 3928 3936 +8
Lines 54781 54806 +25
Branches 9314 9306 -8
============================================
+ Hits 33372 33385 +13
- Misses 18571 18585 +14
+ Partials 2838 2836 -2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20562?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...harding/exception/CursorNameNotFoundException.java](https://codecov.io/gh/apache/shardingsphere/pull/20562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvZXhjZXB0aW9uL0N1cnNvck5hbWVOb3RGb3VuZEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...on/InconsistentShardingTableMetaDataException.java](https://codecov.io/gh/apache/shardingsphere/pull/20562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvZXhjZXB0aW9uL0luY29uc2lzdGVudFNoYXJkaW5nVGFibGVNZXRhRGF0YUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ding/exception/ShardingValueDataTypeException.java](https://codecov.io/gh/apache/shardingsphere/pull/20562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvZXhjZXB0aW9uL1NoYXJkaW5nVmFsdWVEYXRhVHlwZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ding/metadata/ShardingSchemaMetaDataDecorator.java](https://codecov.io/gh/apache/shardingsphere/pull/20562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvbWV0YWRhdGEvU2hhcmRpbmdTY2hlbWFNZXRhRGF0YURlY29yYXRvci5qYXZh) | `36.84% <0.00%> (+4.02%)` | :arrow_up: |
| [...sphere/sharding/route/engine/condition/Column.java](https://codecov.io/gh/apache/shardingsphere/pull/20562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL2NvbmRpdGlvbi9Db2x1bW4uamF2YQ==) | `90.00% <0.00%> (ø)` | |
| [...ngine/impl/WhereClauseShardingConditionEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/20562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL2NvbmRpdGlvbi9lbmdpbmUvaW1wbC9XaGVyZUNsYXVzZVNoYXJkaW5nQ29uZGl0aW9uRW5naW5lLmphdmE=) | `65.82% <0.00%> (ø)` | |
| [...cutor/sql/process/model/ExecuteProcessContext.java](https://codecov.io/gh/apache/shardingsphere/pull/20562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9wcm9jZXNzL21vZGVsL0V4ZWN1dGVQcm9jZXNzQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...executor/sql/process/model/ExecuteProcessUnit.java](https://codecov.io/gh/apache/shardingsphere/pull/20562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9wcm9jZXNzL21vZGVsL0V4ZWN1dGVQcm9jZXNzVW5pdC5qYXZh) | `0.00% <ø> (ø)` | |
| [...ess/model/yaml/BatchYamlExecuteProcessContext.java](https://codecov.io/gh/apache/shardingsphere/pull/20562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9wcm9jZXNzL21vZGVsL3lhbWwvQmF0Y2hZYW1sRXhlY3V0ZVByb2Nlc3NDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../process/model/yaml/YamlExecuteProcessContext.java](https://codecov.io/gh/apache/shardingsphere/pull/20562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9wcm9jZXNzL21vZGVsL3lhbWwvWWFtbEV4ZWN1dGVQcm9jZXNzQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [37 more](https://codecov.io/gh/apache/shardingsphere/pull/20562/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb merged pull request #20562: Reduce foreach call times and object create times
Posted by GitBox <gi...@apache.org>.
zjcnb merged PR #20562:
URL: https://github.com/apache/shardingsphere/pull/20562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org