You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/10 04:22:40 UTC
[GitHub] [dolphinscheduler] EricGao888 opened a new pull request, #10399: [Bug][Tools] Add datasource url for mysql profile in tools application.yaml
EricGao888 opened a new pull request, #10399:
URL: https://github.com/apache/dolphinscheduler/pull/10399
## Purpose of the pull request
* Add datasource url for mysql profile in tools application.yaml
* This PR closes: #10390
## Brief change log
* Already described above.
## Verify this pull request
* Verified by manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #10399: [Bug][Tools] Add datasource url for mysql profile in tools application.yaml
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #10399:
URL: https://github.com/apache/dolphinscheduler/pull/10399#issuecomment-1155109737
> And did we still need this if only work for someone who run database service in the same host with tools script running?
Hi, as I said in https://github.com/apache/dolphinscheduler/pull/10399#issuecomment-1153797154 we can have this default value for the sake of convenience, and can be referenced if users want to configure their own database address (copy this by replacing the IP/host).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #10399: [Bug][Tools] Add datasource url for mysql profile in tools application.yaml
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #10399:
URL: https://github.com/apache/dolphinscheduler/pull/10399#issuecomment-1151930739
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10399?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10399](https://codecov.io/gh/apache/dolphinscheduler/pull/10399?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa7cc0c) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/3258438f6eaf59556fb4c495d532864b257b4c33?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3258438) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## dev #10399 +/- ##
============================================
+ Coverage 40.56% 40.57% +0.01%
- Complexity 4766 4769 +3
============================================
Files 877 877
Lines 35621 35621
Branches 3945 3945
============================================
+ Hits 14449 14454 +5
+ Misses 19737 19733 -4
+ Partials 1435 1434 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/10399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...r/plugin/task/sqoop/parameter/SqoopParameters.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10399/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stc3Fvb3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3Rhc2svc3Fvb3AvcGFyYW1ldGVyL1Nxb29wUGFyYW1ldGVycy5qYXZh) | `53.33% <0.00%> (ø)` | |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10399/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `53.52% <0.00%> (+2.81%)` | :arrow_up: |
| [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10399/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `83.33% <0.00%> (+5.55%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10399?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10399?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3258438...aa7cc0c](https://codecov.io/gh/apache/dolphinscheduler/pull/10399?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10399: [Bug][Tools] Add datasource url for mysql profile in tools application.yaml
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #10399:
URL: https://github.com/apache/dolphinscheduler/pull/10399#issuecomment-1153665895
> @EricGao888 could you try it again after #10414 merged
@zhongjiajie @SbloodyS It works fine now. I'm quite curious about how you guys made it work? How did PR #10414 affect `upgrade-schema.sh`? Very interesting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #10399: [Bug][Tools] Add datasource url for mysql profile in tools application.yaml
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #10399:
URL: https://github.com/apache/dolphinscheduler/pull/10399#issuecomment-1153797154
> > If we set database to mysql in dolphinscheduler_env.sh, when running upgrade-schema.sh in tools, will get errors like Caused by: java.lang.RuntimeException: Driver com.mysql.cj.jdbc.Driver claims to not accept jdbcUrl, jdbc:postgresql://127.0.0.1:5432/dolphinscheduler
>
>
>
> Does it means we should also set `SPRING_DATASOURCE_URL` in `dolphinscheduler_env.sh`. you adding in this PR only a default value of database connection, if user database not in the same mechine of dolphinscheduler service it will throw error too.
We don't need to set that. What we want in the yaml is indeed default value. So before and after this PR when users set up in their production environment they are expected to set `SPRING_DATASOURCE_URL`. This PR is just for convenience that some users/developers want to test locally and the MYSQL url happens to be localhost.
P.S. the reason why I write `export SPRING_DATASOURCE_URL` without a value is that, users might just set the variable without exporting it, that might not work in Spring so we just export it with the value users set.
```shell
SPRING_DATASOURCE_URL=xxxx # note no "export"
daemon.sh start standalone-server
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10399: [Bug][Tools] Add datasource url for mysql profile in tools application.yaml
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10399:
URL: https://github.com/apache/dolphinscheduler/pull/10399#issuecomment-1151934394
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10399)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10399&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10399&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10399&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10399&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10399&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10399&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10399&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10399&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10399&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10399&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10399&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10399&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10399&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10399&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10399: [Bug][Tools] Add datasource url for mysql profile in tools application.yaml
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #10399:
URL: https://github.com/apache/dolphinscheduler/pull/10399#issuecomment-1153701179
> My understanding has some problems. I'll try locally and talk later
Sure, thx for the explanation : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10399: [Bug][Tools] Add datasource url for mysql profile in tools application.yaml
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10399:
URL: https://github.com/apache/dolphinscheduler/pull/10399#issuecomment-1152129796
Does it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10399: [Bug][Tools] Add datasource url for mysql profile in tools application.yaml
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #10399:
URL: https://github.com/apache/dolphinscheduler/pull/10399#issuecomment-1153522560
> @EricGao888 could you try it again after #10414 merged
Sure, will check it as soon as #10414 merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10399: [Bug][Tools] Add datasource url for mysql profile in tools application.yaml
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10399:
URL: https://github.com/apache/dolphinscheduler/pull/10399#issuecomment-1155101083
And did we still need this if only work for someone who run database service in the same host with tools script running?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 merged pull request #10399: [Bug][Tools] Add datasource url for mysql profile in tools application.yaml
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged PR #10399:
URL: https://github.com/apache/dolphinscheduler/pull/10399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] liqingwang commented on pull request #10399: [Bug][Tools] Add datasource url for mysql profile in tools application.yaml
Posted by GitBox <gi...@apache.org>.
liqingwang commented on PR #10399:
URL: https://github.com/apache/dolphinscheduler/pull/10399#issuecomment-1153683348
`export DATABASE=${DATABASE:-h2}`
This field DATABASE is the key to letting the Spring choose the active profile.
And the active profile will choose the DB `driver-class-name` automatically.
`dolphinscheduler-standalone-server/src/main/bin/start.sh` miss this line.
So you seted the MySQL URL and other information, but the DB `driver-class-name` is still PostgreSQL, So you can see the error is `Caused by: java.lang.RuntimeException: Driver com.mysql.cj.jdbc.Driver claims to not accept jdbcUrl, jdbc:postgresql://127.0.0.1:5432/dolphinscheduler`
And the more detailed information about why we don't need to define URL in YAML file, you can see https://github.com/apache/dolphinscheduler/issues/10103#issuecomment-1131238019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] liqingwang commented on pull request #10399: [Bug][Tools] Add datasource url for mysql profile in tools application.yaml
Posted by GitBox <gi...@apache.org>.
liqingwang commented on PR #10399:
URL: https://github.com/apache/dolphinscheduler/pull/10399#issuecomment-1153700366
My understanding has some problems. I'll try locally and talk later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10399: [Bug][Tools] Add datasource url for mysql profile in tools application.yaml
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10399:
URL: https://github.com/apache/dolphinscheduler/pull/10399#issuecomment-1153520909
could you try it again after #10414 merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10399: [Bug][Tools] Add datasource url for mysql profile in tools application.yaml
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #10399:
URL: https://github.com/apache/dolphinscheduler/pull/10399#issuecomment-1153806509
> > > If we set database to mysql in dolphinscheduler_env.sh, when running upgrade-schema.sh in tools, will get errors like Caused by: java.lang.RuntimeException: Driver com.mysql.cj.jdbc.Driver claims to not accept jdbcUrl, jdbc:postgresql://127.0.0.1:5432/dolphinscheduler
> >
> >
> > Does it means we should also set `SPRING_DATASOURCE_URL` in `dolphinscheduler_env.sh`. you adding in this PR only a default value of database connection, if user database not in the same mechine of dolphinscheduler service it will throw error too.
>
> We don't need to set that. What we want in the yaml is indeed default value. So before and after this PR when users set up in their production environment they are expected to set `SPRING_DATASOURCE_URL`. This PR is just for convenience that some users/developers want to test locally and the MYSQL url happens to be localhost.
>
> P.S. the reason why I write `export SPRING_DATASOURCE_URL` without a value is that, users might just set the variable without exporting it, that might not work in Spring so we just export it with the value users set.
>
> ```shell
> SPRING_DATASOURCE_URL=xxxx # note no "export"
> daemon.sh start standalone-server
> ```
This makes sense to me. `username` and `password` are easily kept in mind, but `jdbc:mysql://127.0.0.1:3306/dolphinscheduler?useUnicode=true&characterEncoding=UTF-8` is hardly possible. Add this default value in application.yaml will save the trouble copying pasting every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org