You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/19 08:48:05 UTC
[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9521: [improvement][performance] improve lru cache resize performance and memory usage
yiguolei commented on code in PR #9521:
URL: https://github.com/apache/incubator-doris/pull/9521#discussion_r876790065
##########
be/src/olap/lru_cache.cpp:
##########
@@ -73,9 +73,6 @@ uint32_t CacheKey::hash(const char* data, size_t n, uint32_t seed) const {
Cache::~Cache() {}
HandleTable::~HandleTable() {
- for (uint32_t i = 0; i < _length; i++) {
- delete _list[i];
Review Comment:
should not delete this codeļ¼ maybe memory leak here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org