[jira] [Commented] (AMBARI-7210) BE: Stack advisor scripts should report python errors in API

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126139#comment-14126139 ] 

Hudson commented on AMBARI-7210:
--------------------------------

FAILURE: Integrated in Ambari-trunk-Commit #176 (See [https://builds.apache.org/job/Ambari-trunk-Commit/176/])
AMBARI-7210. BE: Stack advisor scripts should report python errors in API (sgunturi: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=d49c19645d9ef134491b0c225a9235def1a5ac99)
* ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
* ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java
* ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRunnerTest.java
* ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java
* ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelper.java
* ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
* ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequestException.java
* ambari-server/src/main/resources/scripts/stack_advisor.py
* ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRunner.java


> BE: Stack advisor scripts should report python errors in API
> ------------------------------------------------------------
>
>                 Key: AMBARI-7210
>                 URL: https://issues.apache.org/jira/browse/AMBARI-7210
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server
>    Affects Versions: 1.7.0
>            Reporter: Srimanth Gunturi
>            Assignee: Srimanth Gunturi
>             Fix For: 1.7.0
>
>         Attachments: AMBARI-7210.patch
>
>
> If anything goes wrong in the stack-advisor scripts, it should be propagated to the API response so that the user can take appropriate action. 
> For example in script's main() I threw an exception
> {code}
> raise StackAdvisorException("I will fail!")
> {code}
> However the API response was 
> {code}
> 400 - Bad Request
> Error occured during stack advisor command invocation
> {code}
> Any _StackAdvisorException_ means a semantic issues, and should be reported as {{400-Bad Request <message>}}. 
> Any other exceptions should be returned as {{500-Internal Server Error <message>}}.
> Any other types of failures should also be accounted for (compilation issues, NPEs, etc.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)