You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Isuru Haththotuwa <is...@apache.org> on 2015/05/11 10:35:35 UTC
Validating Startup and Scaling Dependency Prefixes at Group
Deployment Time
Hi Devs,
In [1, 2], we have code explicitly depending on two prefixes used for
startup order and scaling order, *'cartridge.*' and '*group.'* .IMHO we
should validate this at Service Group deployment time, since otherwise
startup order / scaling will not work as expected. Currently its possible
to deploy a Group Definition with a startup order without these prefixes.
I'll fix this.
[1].
org.apache.stratos.autoscaler.applications.dependency.DependencyBuilder
[2]. org.apache.stratos.autoscaler.applications.parser.ParserUtils
--
Thanks and Regards,
Isuru H.
+94 716 358 048* <http://wso2.com/>*
* <http://wso2.com/>*
Re: Validating Startup and Scaling Dependency Prefixes at Group
Deployment Time
Posted by Reka Thirunavukkarasu <re...@wso2.com>.
+1 for validating it in the service deployment as well. Do we have a
validation against the alias for startupOrder which defined in the service
group when deploying application?
Thanks,
Reka
On Mon, May 11, 2015 at 4:45 PM, Isuru Haththotuwa <is...@apache.org>
wrote:
> Fixed in commit b0ef0ccf3491610cf5fbec10b40e955fa31823d3.
>
> On Mon, May 11, 2015 at 2:33 PM, Udara Liyanage <ud...@wso2.com> wrote:
>
>> +1
>>
>> On Mon, May 11, 2015 at 2:05 PM, Isuru Haththotuwa <is...@apache.org>
>> wrote:
>>
>>> Hi Devs,
>>>
>>> In [1, 2], we have code explicitly depending on two prefixes used for
>>> startup order and scaling order, *'cartridge.*' and '*group.'* .IMHO we
>>> should validate this at Service Group deployment time, since otherwise
>>> startup order / scaling will not work as expected. Currently its possible
>>> to deploy a Group Definition with a startup order without these prefixes.
>>> I'll fix this.
>>>
>>> [1].
>>> org.apache.stratos.autoscaler.applications.dependency.DependencyBuilder
>>> [2]. org.apache.stratos.autoscaler.applications.parser.ParserUtils
>>>
>>>
>>> --
>>> Thanks and Regards,
>>>
>>> Isuru H.
>>> +94 716 358 048* <http://wso2.com/>*
>>>
>>>
>>> * <http://wso2.com/>*
>>>
>>>
>>>
>>
>>
>> --
>>
>> Udara Liyanage
>> Software Engineer
>> WSO2, Inc.: http://wso2.com
>> lean. enterprise. middleware
>>
>> web: http://udaraliyanage.wordpress.com
>> phone: +94 71 443 6897
>>
>> --
>> Thanks and Regards,
>>
>> Isuru H.
>> +94 716 358 048* <http://wso2.com/>*
>>
>>
>> * <http://wso2.com/>*
>>
>>
>>
--
Reka Thirunavukkarasu
Senior Software Engineer,
WSO2, Inc.:http://wso2.com,
Mobile: +94776442007
Re: Validating Startup and Scaling Dependency Prefixes at Group
Deployment Time
Posted by Isuru Haththotuwa <is...@apache.org>.
Fixed in commit b0ef0ccf3491610cf5fbec10b40e955fa31823d3.
On Mon, May 11, 2015 at 2:33 PM, Udara Liyanage <ud...@wso2.com> wrote:
> +1
>
> On Mon, May 11, 2015 at 2:05 PM, Isuru Haththotuwa <is...@apache.org>
> wrote:
>
>> Hi Devs,
>>
>> In [1, 2], we have code explicitly depending on two prefixes used for
>> startup order and scaling order, *'cartridge.*' and '*group.'* .IMHO we
>> should validate this at Service Group deployment time, since otherwise
>> startup order / scaling will not work as expected. Currently its possible
>> to deploy a Group Definition with a startup order without these prefixes.
>> I'll fix this.
>>
>> [1].
>> org.apache.stratos.autoscaler.applications.dependency.DependencyBuilder
>> [2]. org.apache.stratos.autoscaler.applications.parser.ParserUtils
>>
>>
>> --
>> Thanks and Regards,
>>
>> Isuru H.
>> +94 716 358 048* <http://wso2.com/>*
>>
>>
>> * <http://wso2.com/>*
>>
>>
>>
>
>
> --
>
> Udara Liyanage
> Software Engineer
> WSO2, Inc.: http://wso2.com
> lean. enterprise. middleware
>
> web: http://udaraliyanage.wordpress.com
> phone: +94 71 443 6897
>
> --
> Thanks and Regards,
>
> Isuru H.
> +94 716 358 048* <http://wso2.com/>*
>
>
> * <http://wso2.com/>*
>
>
>
Re: Validating Startup and Scaling Dependency Prefixes at Group
Deployment Time
Posted by Udara Liyanage <ud...@wso2.com>.
+1
On Mon, May 11, 2015 at 2:05 PM, Isuru Haththotuwa <is...@apache.org>
wrote:
> Hi Devs,
>
> In [1, 2], we have code explicitly depending on two prefixes used for
> startup order and scaling order, *'cartridge.*' and '*group.'* .IMHO we
> should validate this at Service Group deployment time, since otherwise
> startup order / scaling will not work as expected. Currently its possible
> to deploy a Group Definition with a startup order without these prefixes.
> I'll fix this.
>
> [1].
> org.apache.stratos.autoscaler.applications.dependency.DependencyBuilder
> [2]. org.apache.stratos.autoscaler.applications.parser.ParserUtils
>
>
> --
> Thanks and Regards,
>
> Isuru H.
> +94 716 358 048* <http://wso2.com/>*
>
>
> * <http://wso2.com/>*
>
>
>
--
Udara Liyanage
Software Engineer
WSO2, Inc.: http://wso2.com
lean. enterprise. middleware
web: http://udaraliyanage.wordpress.com
phone: +94 71 443 6897