You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "hailin0 (via GitHub)" <gi...@apache.org> on 2023/04/17 15:02:54 UTC
[GitHub] [incubator-seatunnel] hailin0 opened a new pull request, #4598: [Hotfix][Connector] Fixed TDengine connector using jdbc driver to cause loading error
hailin0 opened a new pull request, #4598:
URL: https://github.com/apache/incubator-seatunnel/pull/4598
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Due to the use of different class loaders between Enumerator and Reader/Writer, loading the JDBC driver resulted in an error. To avoid this error, the logic for calling the JDBC driver in Enumerator was moved to the Source#prepare method, which is executed on the client side.
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 merged pull request #4598: [Hotfix][Connector] Fixed TDengine connector using jdbc driver to cause loading error
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 merged PR #4598:
URL: https://github.com/apache/incubator-seatunnel/pull/4598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] lhyundeadsoul commented on pull request #4598: [Hotfix][Connector] Fixed TDengine connector using jdbc driver to cause loading error
Posted by "lhyundeadsoul (via GitHub)" <gi...@apache.org>.
lhyundeadsoul commented on PR #4598:
URL: https://github.com/apache/incubator-seatunnel/pull/4598#issuecomment-1514078901
> @lhyundeadsoul PTAL
@hailin0 Thx for your great job, it looks much more clear now.
But I still haven't figured it out:
1. why do Enumerator and Reader/Writer use different class loaders?
2. what is the detail of the error?
3. Why do errors occur when using different class loaders?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #4598: [Hotfix][Connector] Fixed TDengine connector using jdbc driver to cause loading error
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #4598:
URL: https://github.com/apache/incubator-seatunnel/pull/4598#issuecomment-1511546603
@lhyundeadsoul PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org