You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by "Hugo Hirsch (Created) (JIRA)" <ji...@apache.org> on 2011/11/22 22:06:40 UTC

[jira] [Created] (RAT-104) Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10

Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10
--------------------------------------------------------------------------------------------------------

                 Key: RAT-104
                 URL: https://issues.apache.org/jira/browse/RAT-104
             Project: RAT
          Issue Type: Improvement
          Components: maven
    Affects Versions: 0.9
            Reporter: Hugo Hirsch


I'd like to migrate all tests from JUnit3 to annotation based JUnit4 tests - in order to do so the pom's need to be adapted.

Any objections?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (RAT-104) Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10

Posted by "Hugo Hirsch (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/RAT-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157734#comment-13157734 ] 

Hugo Hirsch commented on RAT-104:
---------------------------------

When I try to run a JUnit4-test (with static imports) with the current pom I get:
{code}
 Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.1:testCompile (default-testCompile) on project apache-rat-core: Compilation failure: Compilation failure:
[ERROR] /home/hirsch/Documents/workspace/rat-plugin/apache-rat-core/src/test/java/org/apache/rat/analysis/license/GPL3LicenseTest.java:[7,7] error: static import declarations are not supported in -source 1.4
[ERROR] 
[ERROR] (use -source 5 or higher to enable static import declarations)
{code}

Thus the code level needs to be raised to 1.5.

What are the objections to update to Java5 at all?

Apart from static imports there are other nice things that could be added :-)


                
> Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10
> --------------------------------------------------------------------------------------------------------
>
>                 Key: RAT-104
>                 URL: https://issues.apache.org/jira/browse/RAT-104
>             Project: RAT
>          Issue Type: Improvement
>          Components: maven
>    Affects Versions: 0.9
>            Reporter: Hugo Hirsch
>              Labels: maven
>         Attachments: RAT104patchedPomXmlWithJunit410AndVersionPropertyValue_r1205166.txt
>
>
> I'd like to migrate all tests from JUnit3 to annotation based JUnit4 tests - in order to do so the pom's need to be adapted.
> Any objections?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Reopened] (RAT-104) Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10

Posted by "Hugo Hirsch (Reopened) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/RAT-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hugo Hirsch reopened RAT-104:
-----------------------------


Since RAT-59 is not resolved no native JUnit4 test can be added to the trunk.
                
> Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10
> --------------------------------------------------------------------------------------------------------
>
>                 Key: RAT-104
>                 URL: https://issues.apache.org/jira/browse/RAT-104
>             Project: RAT
>          Issue Type: Improvement
>          Components: maven
>    Affects Versions: 0.9
>            Reporter: Hugo Hirsch
>              Labels: maven
>         Attachments: RAT104patchedPomXmlWithJunit410AndVersionPropertyValue_r1205166.txt
>
>
> I'd like to migrate all tests from JUnit3 to annotation based JUnit4 tests - in order to do so the pom's need to be adapted.
> Any objections?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (RAT-104) Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10

Posted by "Hugo Hirsch (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/RAT-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hugo Hirsch updated RAT-104:
----------------------------

    Attachment: RAT104patchedPomXmlWithJunit410AndVersionPropertyValue_r1205166.txt

Patched pom.xml to work with Junit 4.10 instead of old version.
                
> Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10
> --------------------------------------------------------------------------------------------------------
>
>                 Key: RAT-104
>                 URL: https://issues.apache.org/jira/browse/RAT-104
>             Project: RAT
>          Issue Type: Improvement
>          Components: maven
>    Affects Versions: 0.9
>            Reporter: Hugo Hirsch
>              Labels: maven
>         Attachments: RAT104patchedPomXmlWithJunit410AndVersionPropertyValue_r1205166.txt
>
>
> I'd like to migrate all tests from JUnit3 to annotation based JUnit4 tests - in order to do so the pom's need to be adapted.
> Any objections?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (RAT-104) Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10

Posted by "Stefan Bodewig (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/RAT-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Bodewig resolved RAT-104.
--------------------------------

    Resolution: Fixed

Gump is using JUnit's trunk when building/testing RAT so I know it won't hurt to upgrade.

This means Java5 is now required at build time but I don't expect that to be an issue.

Fixed with svn revision 1206203
                
> Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10
> --------------------------------------------------------------------------------------------------------
>
>                 Key: RAT-104
>                 URL: https://issues.apache.org/jira/browse/RAT-104
>             Project: RAT
>          Issue Type: Improvement
>          Components: maven
>    Affects Versions: 0.9
>            Reporter: Hugo Hirsch
>              Labels: maven
>         Attachments: RAT104patchedPomXmlWithJunit410AndVersionPropertyValue_r1205166.txt
>
>
> I'd like to migrate all tests from JUnit3 to annotation based JUnit4 tests - in order to do so the pom's need to be adapted.
> Any objections?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (RAT-104) Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10

Posted by "Stefan Bodewig (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/RAT-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157677#comment-13157677 ] 

Stefan Bodewig commented on RAT-104:
------------------------------------

Using JUnit 4.x means Java5 at build/test time while RAT-59 means Java5 at runtime.

                
> Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10
> --------------------------------------------------------------------------------------------------------
>
>                 Key: RAT-104
>                 URL: https://issues.apache.org/jira/browse/RAT-104
>             Project: RAT
>          Issue Type: Improvement
>          Components: maven
>    Affects Versions: 0.9
>            Reporter: Hugo Hirsch
>              Labels: maven
>         Attachments: RAT104patchedPomXmlWithJunit410AndVersionPropertyValue_r1205166.txt
>
>
> I'd like to migrate all tests from JUnit3 to annotation based JUnit4 tests - in order to do so the pom's need to be adapted.
> Any objections?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (RAT-104) Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10

Posted by "Stefan Bodewig (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/RAT-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Bodewig resolved RAT-104.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.9

RAT-59 has been fixed now.
                
> Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10
> --------------------------------------------------------------------------------------------------------
>
>                 Key: RAT-104
>                 URL: https://issues.apache.org/jira/browse/RAT-104
>             Project: RAT
>          Issue Type: Improvement
>          Components: maven
>    Affects Versions: 0.9
>            Reporter: Hugo Hirsch
>              Labels: maven
>             Fix For: 0.9
>
>         Attachments: RAT104patchedPomXmlWithJunit410AndVersionPropertyValue_r1205166.txt
>
>
> I'd like to migrate all tests from JUnit3 to annotation based JUnit4 tests - in order to do so the pom's need to be adapted.
> Any objections?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (RAT-104) Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10

Posted by "Hugo Hirsch (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/RAT-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157447#comment-13157447 ] 

Hugo Hirsch edited comment on RAT-104 at 11/26/11 12:48 PM:
------------------------------------------------------------

I'm not sure whether the switch to Java 1.5 relates to 
https://issues.apache.org/jira/browse/RAT-59

Perhaps this can be performed as well ?
Otherwise a real JUnit4 test will fail since sourceCode level still is 1.4 and thus no annotations are supported.
                
      was (Author: hugo.hirsch):
    I'm not sure whether the switch to Java 1.5 relates to 
https://issues.apache.org/jira/browse/RAT-59

Perhaps this can be performed as well ?
                  
> Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10
> --------------------------------------------------------------------------------------------------------
>
>                 Key: RAT-104
>                 URL: https://issues.apache.org/jira/browse/RAT-104
>             Project: RAT
>          Issue Type: Improvement
>          Components: maven
>    Affects Versions: 0.9
>            Reporter: Hugo Hirsch
>              Labels: maven
>         Attachments: RAT104patchedPomXmlWithJunit410AndVersionPropertyValue_r1205166.txt
>
>
> I'd like to migrate all tests from JUnit3 to annotation based JUnit4 tests - in order to do so the pom's need to be adapted.
> Any objections?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (RAT-104) Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10

Posted by "Hugo Hirsch (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/RAT-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157447#comment-13157447 ] 

Hugo Hirsch commented on RAT-104:
---------------------------------

I'm not sure whether the switch to Java 1.5 relates to 
https://issues.apache.org/jira/browse/RAT-59

Perhaps this can be performed as well ?
                
> Using jUnit4 annotation based tests instead of junit3 - migration from junit 3.8.2 to current junit 4.10
> --------------------------------------------------------------------------------------------------------
>
>                 Key: RAT-104
>                 URL: https://issues.apache.org/jira/browse/RAT-104
>             Project: RAT
>          Issue Type: Improvement
>          Components: maven
>    Affects Versions: 0.9
>            Reporter: Hugo Hirsch
>              Labels: maven
>         Attachments: RAT104patchedPomXmlWithJunit410AndVersionPropertyValue_r1205166.txt
>
>
> I'd like to migrate all tests from JUnit3 to annotation based JUnit4 tests - in order to do so the pom's need to be adapted.
> Any objections?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira