[GitHub] [pulsar-client-node] hrsakai opened a new pull request #180: Fix cflags_cc for gcc-4.9

[GitBox <gi...@apache.org>]

hrsakai opened a new pull request #180:
URL: https://github.com/apache/pulsar-client-node/pull/180


   When compiling pulsar-client-node with gcc4.9 and node v16.5.0, build failed with following error.
   ```
   g++: error: unrecognized command line option ‘-std=gnu++14’
   make: *** [Release/obj.target/Pulsar/src/addon.o] Error 1
   make: Leaving directory `/root/pulsar-client-node/build'
   ```
   
   Gcc4.9 does not support `-std=gnu++14` option, but this option was added to common.gypi intead of `-std=gnu++1y` from node v16.2.0.
   https://github.com/nodejs/node/blob/v16.2.0/common.gypi#L378
   
   Also added `-std=gnu++17` option from node v17.1.0.
   https://github.com/nodejs/node/blob/v17.1.0/common.gypi#L388
   
   ## Modification
   Add `-std=gnu++11` option to `cflags_cc` and remove `-std=gnu++14/17` options from it because pulsar-client-node can be compiled with just `-std=gnu++11` option.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-node] massakam merged pull request #180: Fix cflags_cc for gcc-4.9

[GitBox <gi...@apache.org>]

massakam merged pull request #180:
URL: https://github.com/apache/pulsar-client-node/pull/180


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org