[jira] [Resolved] (CALCITE-1780) Add `required Order` and `requiresOver` parameters to the constructor of `SqlUserDefinedAggregate Function`

["Julian Hyde (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Hyde resolved CALCITE-1780.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.13.0

Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/7c7e932e. Thanks for the PR, [~sunjincheng121]!

> Add `required Order` and `requiresOver` parameters to the constructor of `SqlUserDefinedAggregate Function`
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-1780
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1780
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>             Fix For: 1.13.0
>
>
> Currently {{org.apache.calcite.sql.validate.SqlUserDefinedAggFunction}} calls the constructor of SqlAggFunction:
> {code}
> Protected SqlAggFunction (
>        String name,
>        SqlIdentifier sqlIdentifier,
>        SqlKind kind,
>        SqlReturnTypeInference returnTypeInference,
>        SqlOperandTypeInference operandTypeInference,
>        SqlOperandTypeChecker operandTypeChecker,
>        SqlFunctionCategory funcType,
>        Boolean requiresOrder,
>        Boolean requiresOver) 
> {code}
> The requiresOrder = false, requiresOver = false. as follow:
> {code}
> Public SqlUserDefinedAggFunction (SqlIdentifier opName,
>        SqlReturnTypeInference returnTypeInference,
>        SqlOperandTypeInference operandTypeInference,
>        SqlOperandTypeChecker operandTypeChecker, AggregateFunction function) {
>      Super (Util.last (opName.names), opName, SqlKind.OTHER_FUNCTION,
>          ReturnTypeInference, operandTypeInference, operandTypeChecker,
>          SqlFunctionCategory.USER_DEFINED_FUNCTION, false, false);
>      This.function = function;
>    } 
> {code}
> I want add `required Order` and `requiresOver` parameters to the constructor of `SqlUserDefinedAggregate Function`.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)