You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/07/07 12:35:54 UTC
[GitHub] [skywalking-eyes] MoGuGuai-hzr opened a new pull request #36: Fix minor error
MoGuGuai-hzr opened a new pull request #36:
URL: https://github.com/apache/skywalking-eyes/pull/36
Reading an file named `""` will raise the `IsNotExist` error, so the conditional statement is unnecessary in `pkg/config/config.go`
The result should match whether the pattern is `.` or `./`.
Small improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] MoGuGuai-hzr commented on pull request #36: Fix minor error
Posted by GitBox <gi...@apache.org>.
MoGuGuai-hzr commented on pull request #36:
URL: https://github.com/apache/skywalking-eyes/pull/36#issuecomment-876027662
>
>
> > Reading an file named `""` will raise the `IsNotExist` error, so the conditional statement is unnecessary in `pkg/config/config.go`
> > The result should match whether the pattern is `.` or `./`.
> > Small improvement.
>
> Thanks for the feedback, where are you going to use SkyWalking-eye tool?
Yes, i will. And i am a student participating Summer 2021 of Open Source Promotion Plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] wu-sheng commented on pull request #36: Fix minor error
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #36:
URL: https://github.com/apache/skywalking-eyes/pull/36#issuecomment-875584777
> Reading an file named `""` will raise the `IsNotExist` error, so the conditional statement is unnecessary in `pkg/config/config.go`
>
> The result should match whether the pattern is `.` or `./`.
>
> Small improvement.
Thanks for the feedback, where are you going to use SkyWalking-eye tool?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 merged pull request #36: Fix minor error
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #36:
URL: https://github.com/apache/skywalking-eyes/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org