You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/23 04:33:05 UTC

[GitHub] [shardingsphere-elasticjob] wwj-go opened a new pull request #1640: No empty elasticJobType and elasticJob

wwj-go opened a new pull request #1640:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1640


   Simplify code
   
   Changes proposed in this pull request:
   - No empty elasticJobType and elasticJob for JobScheduler 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1640: No empty elasticJobType and elasticJob

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1640:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1640#issuecomment-714939862


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1640?src=pr&el=h1) Report
   > Merging [#1640](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1640?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/7edcb3849f57fd70285df85b4ebd89d5536efa41?el=desc) will **decrease** coverage by `0.17%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1640/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1640?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1640      +/-   ##
   ============================================
   - Coverage     86.00%   85.82%   -0.18%     
     Complexity      102      102              
   ============================================
     Files           247      247              
     Lines          5636     5636              
     Branches        873      873              
   ============================================
   - Hits           4847     4837      -10     
   - Misses          477      486       +9     
   - Partials        312      313       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1640?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...lasticjob/lite/internal/schedule/JobScheduler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1640/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2NoZWR1bGUvSm9iU2NoZWR1bGVyLmphdmE=) | `77.27% <33.33%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../elasticjob/lite/internal/storage/JobNodePath.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1640/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc3RvcmFnZS9Kb2JOb2RlUGF0aC5qYXZh) | `77.77% <0.00%> (-22.23%)` | `0.00% <0.00%> (ø%)` | |
   | [...ob/lite/api/bootstrap/impl/OneOffJobBootstrap.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1640/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvYXBpL2Jvb3RzdHJhcC9pbXBsL09uZU9mZkpvYkJvb3RzdHJhcC5qYXZh) | `64.28% <0.00%> (-18.07%)` | `0.00% <0.00%> (ø%)` | |
   | [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1640/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `77.77% <0.00%> (-4.77%)` | `1.00% <0.00%> (ø%)` | |
   | [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1640/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
   | [...lasticjob/lite/internal/instance/InstanceNode.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1640/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvaW5zdGFuY2UvSW5zdGFuY2VOb2RlLmphdmE=) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ticjob/lite/internal/instance/InstanceService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1640/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvaW5zdGFuY2UvSW5zdGFuY2VTZXJ2aWNlLmphdmE=) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1640?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1640?src=pr&el=footer). Last update [7edcb38...ea426ea](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1640?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] terrymanu merged pull request #1640: No empty elasticJobType and elasticJob

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #1640:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1640


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org