[jira] [Commented] (GIRAPH-324) Add option to use combiner in benchmarks

["Giraph QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454111#comment-13454111 ] 

Giraph QA commented on GIRAPH-324:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12544834/GIRAPH-324.patch
  against trunk revision 1383115.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The applied patch does not increase the total number of javadoc warnings.

    +1 checkstyle.  The patch generated 0 code style errors.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in ..

Test results: https://builds.apache.org/job/PreCommit-GIRAPH-Build/40//testReport/
Console output: https://builds.apache.org/job/PreCommit-GIRAPH-Build/40//console

This message is automatically generated.
                
> Add option to use combiner in benchmarks
> ----------------------------------------
>
>                 Key: GIRAPH-324
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-324
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>            Priority: Minor
>         Attachments: GIRAPH-324.patch
>
>
> ShortestPathsBenchmark already uses MinimumDoubleCombiner by default.
> With this patch, PageRankBenchmark will also use DoubleSumCombiner.
> Adding the option "-nc" to either benchmark disables the combiner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira