You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/09/16 23:47:45 UTC

[GitHub] [pinot] Jackie-Jiang opened a new issue, #9418: Add read APIs for `BOOLEAN` and `TIMESTAMP`

Jackie-Jiang opened a new issue, #9418:
URL: https://github.com/apache/pinot/issues/9418

   Currently `BOOLEAN` is supported using the `INT` data type, and `TIMESTAMP` is supported using the `LONG` data type. Even though the storage format are the same, the behavior should be different. E.g. reading `BOOLEAN` as `STRING` should give `"true"` or `"false"` instead of `1` or `0`; reading `DOUBLE` as `BOOLEAN` should give `doubleVal != 0` instead of `(int) doubleVal`.
   In order to achieve the expected behavior, we need to add read APIs for these 2 data types. It should be similar to how the `BIG_DECIMAL` is handled (storage format is `BYTES`). We want to add type support in:
   - Dictionary
   - ForwardIndexReader
   - BlockValSet
   - TransformFunction


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] ddcprg commented on issue #9418: Add read APIs for `BOOLEAN` and `TIMESTAMP`

Posted by "ddcprg (via GitHub)" <gi...@apache.org>.
ddcprg commented on issue #9418:
URL: https://github.com/apache/pinot/issues/9418#issuecomment-1536026019

   @jonasgeiregat I was close to complete this but never did. Unfortunately, I've been away from this project for a while now, hope I can start contributing again in the future. I'm happy if @Jackie-Jiang assigns this to you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang commented on issue #9418: Add read APIs for `BOOLEAN` and `TIMESTAMP`

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #9418:
URL: https://github.com/apache/pinot/issues/9418#issuecomment-1284661603

   @ddcprg Thanks for volunteering, assigned to you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] ddcprg commented on issue #9418: Add read APIs for `BOOLEAN` and `TIMESTAMP`

Posted by GitBox <gi...@apache.org>.
ddcprg commented on issue #9418:
URL: https://github.com/apache/pinot/issues/9418#issuecomment-1282188016

   hey @Jackie-Jiang is someone working on this issue? I could pick this if no one is on it 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] jonasgeiregat commented on issue #9418: Add read APIs for `BOOLEAN` and `TIMESTAMP`

Posted by "jonasgeiregat (via GitHub)" <gi...@apache.org>.
jonasgeiregat commented on issue #9418:
URL: https://github.com/apache/pinot/issues/9418#issuecomment-1531905973

   @ddcprg are you still looking into this ? 
   It looks like an interesting issue to tackle for a beginner. 
   I'm willing to help out if needed ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] jonasgeiregat commented on issue #9418: Add read APIs for `BOOLEAN` and `TIMESTAMP`

Posted by "jonasgeiregat (via GitHub)" <gi...@apache.org>.
jonasgeiregat commented on issue #9418:
URL: https://github.com/apache/pinot/issues/9418#issuecomment-1536380560

   @ddcprg if you were close it would be interesting to look into your approach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org