[jira] Commented: (WHIRR-106) improve logging in whirr cli

["Adrian Cole (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WHIRR-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917403#action_12917403 ] 

Adrian Cole commented on WHIRR-106:
-----------------------------------

wrt slj4j in jclouds, I've considered it.  Personally, I'm not a big fan of using the classloader as a DI tool.  I do like the recent shift to null loggers, which we did over a year ago.  However, there's really never been a log-related feature we've needed and are lacking.

More importantly, slf4j isn't defacto: rather it is one of several popular log apis.  While light, it still represents a dependency those who just use log4j, java logging (or run in google appengine, android, etc) wouldn't care to bring in.  Log veneers are extremely short and easy to maintain code.  It is an easy burden to accept on behalf of the users.

That said, we will make a slf4j adapter, so that those who use it can have that supported in jclouds.  That makes total sense and I've logged this below:

http://code.google.com/p/jclouds/issues/detail?id=374

> improve logging in whirr cli
> ----------------------------
>
>                 Key: WHIRR-106
>                 URL: https://issues.apache.org/jira/browse/WHIRR-106
>             Project: Whirr
>          Issue Type: Bug
>          Components: cli
>    Affects Versions: 0.1.0
>            Reporter: Patrick Hunt
>            Assignee: Tom White
>             Fix For: 0.2.0
>
>         Attachments: log4j.properties, WHIRR-106.patch, WHIRR-106.patch, WHIRR-106.patch
>
>
> I believe there are two issues here:
> 1) services are not logging anything 
> 2) logging output does not seem to be setup correctly
> for 1) we should add info level (at least) messages to the service implementations to indicate progress
> for 2) we should include a default log4j.properties (or xml) in the shaded jar which has sane defaults (see attachment for an example I whipped up and am using myself)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.