You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "divyankshah (via GitHub)" <gi...@apache.org> on 2026/08/03 21:39:15 UTC

Re: [I] Support parsing Doris sql [shardingsphere]

divyankshah commented on issue #31481:
URL: https://github.com/apache/shardingsphere/issues/31481#issuecomment-5172031918

   Hi, would like to contribute to this issue. Can it be assigned?
   
   Below is my Approach: I verified against the current Doris docs that LAG/BITXOR and most of the listed ALTER DATABASE variants (RENAME, SET DATA/REPLICA QUOTA) already parse correctly in the current grammar and are covered by existing tests. 
   
   **The remaining gaps are:**
   1) ALTER WORKLOAD GROUP "rg_name" PROPERTIES(...) where I added a new grammar rule modeled on the existing ALTER STORAGE POLICY ... PROPERTIES(...) pattern, plus the corresponding statement/segment classes and visitor logic.
   2) ALTER DATABASE ... SET DATA QUOTA 100G (unit-suffixed quota values) I have wired the QUOTA clause to reuse the grammar's existing fileSizeLiteral rule (already used elsewhere for SIZE 100M-style literals) instead of a bare number, and convert the K/M/G/T suffix to bytes in the visitor.
   3) Adding .sql/expected-output test cases for both and verified it end to end. 
   
   Will open a PR shortly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org