You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/23 01:12:53 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #849: mm: Fix heap corruption in protected build
Ouss4 opened a new pull request #849:
URL: https://github.com/apache/incubator-nuttx/pull/849
Backport #843
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on issue #849: mm: Fix heap corruption in protected build
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #849:
URL: https://github.com/apache/incubator-nuttx/pull/849#issuecomment-618124728
> I think it's safe but let me get my CI fix in so it will build off the correct branch if it is the release branch.
Ok thanks. @patacongo let's wait for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #849: Backport #843 to releases/9.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #849:
URL: https://github.com/apache/incubator-nuttx/pull/849#issuecomment-618587692
@Ouss4 let's rebase your patch and try whether #850 work as expect
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on issue #849: mm: Fix heap corruption in protected build
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #849:
URL: https://github.com/apache/incubator-nuttx/pull/849#issuecomment-618123210
The changes that Alin did recently to the audio subsystem are not included in the releases/9.0 branch.
When the tests run they pull the latest apps/ (which has the recent changes) and build it with this branch.
It's kind of the same issue where you had to merge that apps/ PR with a build failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #849: Backport #843 to releases/9.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #849:
URL: https://github.com/apache/incubator-nuttx/pull/849#issuecomment-618192696
build.yml always fetch the peer repo from the master which is fine for the daily working, but fail for relese branch. The right strategy is fetch the peer repo base on the branch the PR will appiled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on issue #849: mm: Fix heap corruption in protected build
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #849:
URL: https://github.com/apache/incubator-nuttx/pull/849#issuecomment-618121879
The tests pull apps' master not releases/9.0, that won't pass with the recent audio changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on issue #849: Backport #843 to releases/9.0
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #849:
URL: https://github.com/apache/incubator-nuttx/pull/849#issuecomment-618241075
PR #850 should fix this. It ended up being larger than I wanted, but I think sets us up better to hand matching repos in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #849: Backport #843 to releases/9.0
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #849:
URL: https://github.com/apache/incubator-nuttx/pull/849#issuecomment-618590944
@xiaoxiang781216 I'll need to first bring the last PR to the release branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on issue #849: Backport #843 to releases/9.0
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #849:
URL: https://github.com/apache/incubator-nuttx/pull/849#issuecomment-618427481
So when that PR is merged, we bring it to releases/9.0 and I rebase this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #849: mm: Fix heap corruption in protected build
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #849:
URL: https://github.com/apache/incubator-nuttx/pull/849#issuecomment-618122346
I don't understand the build failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #849: mm: Fix heap corruption in protected build
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #849:
URL: https://github.com/apache/incubator-nuttx/pull/849#issuecomment-618122703
> The tests pull apps' master not releases/9.0, that won't pass with the recent audio changes.
What do you recommend? I think the change is safe, but it must be verified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton edited a comment on issue #849: Backport #843 to releases/9.0
Posted by GitBox <gi...@apache.org>.
btashton edited a comment on issue #849:
URL: https://github.com/apache/incubator-nuttx/pull/849#issuecomment-618131541
I'm going to leave master as the target for nuttx-incubating-testing for now. We can opt to make a release branch later if we want to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on issue #849: mm: Fix heap corruption in protected build
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #849:
URL: https://github.com/apache/incubator-nuttx/pull/849#issuecomment-618122982
I think it's safe but let me get my CI fix in so it will build off the correct branch if it is the release branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on issue #849: Backport #843 to releases/9.0
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #849:
URL: https://github.com/apache/incubator-nuttx/pull/849#issuecomment-618131541
I'm going to leave master as the target for testing for now. We can opt to make a release branch later if we want to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org