You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/12/08 23:10:48 UTC
Review Request 28817: Moved DRFAllocatorTest.SameShareAllocations to
a unit test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28817/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
This moves DRFAllocatorTest.SameShareAllocation into a HierarchicalAllocatorTest.SameShareFairness unit test.
Note that reviewboard cannot display the removal of DRFAllocatorTest.SameShareAllocation, because the file was renamed in an earlier review in the chain. See the raw diff.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp PRE-CREATION
src/tests/master_allocator_tests.cpp d28acbb41fb871efb368aacedddbace761e82eed
Diff: https://reviews.apache.org/r/28817/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 28817: Moved DRFAllocatorTest.SameShareAllocations
to a unit test.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28817/#review64596
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2014, 10:10 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28817/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 10:10 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This moves DRFAllocatorTest.SameShareAllocation into a HierarchicalAllocatorTest.SameShareFairness unit test.
>
> Note that reviewboard cannot display the removal of DRFAllocatorTest.SameShareAllocation, because the file was renamed in an earlier review in the chain. See the raw diff.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp PRE-CREATION
> src/tests/master_allocator_tests.cpp d28acbb41fb871efb368aacedddbace761e82eed
>
> Diff: https://reviews.apache.org/r/28817/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 28817: Moved DRFAllocatorTest.SameShareAllocations
to a unit test.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28817/
-----------------------------------------------------------
(Updated Dec. 11, 2014, 10:12 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Removed unnecessary use of utils::copy.
Repository: mesos-git
Description
-------
This moves DRFAllocatorTest.SameShareAllocation into a HierarchicalAllocatorTest.SameShareFairness unit test.
Note that reviewboard cannot display the removal of DRFAllocatorTest.SameShareAllocation, because the file was renamed in an earlier review in the chain. See the raw diff.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp PRE-CREATION
src/tests/master_allocator_tests.cpp 8de1d2af02ca40b5bbf5eb48546877582fd108a3
Diff: https://reviews.apache.org/r/28817/diff/
Testing
-------
make check
Thanks,
Ben Mahler