[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2095: IGNITE-19506 Use data nodes from DistributionZoneManager with a causality token instead of BaselineManager#nodes

["sanpwc (via GitHub)" <gi...@apache.org>]

sanpwc commented on code in PR #2095:
URL: https://github.com/apache/ignite-3/pull/2095#discussion_r1200294194


##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -793,6 +792,10 @@ public Set<String> dataNodes(int zoneId) {
         });
     }
 
+    public CompletableFuture<Set<String>> versionedDataNodes(int zoneId, long revision) {

Review Comment:
   - I'd rather user `dataNodes` instead of `versionedDataNodes`
   - It's not revision it's causalityToken.
   - causalityToken should be the first parameter, see `org.apache.ignite.internal.table.distributed.TableManager#tableAsync(long, java.util.UUID)` or `org.apache.ignite.internal.index.IndexManager#createIndexLocally` for example.
   - Where's the javadoc?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org