You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by rm...@apache.org on 2012/06/04 22:10:24 UTC

svn commit: r1346137 - in /openejb/trunk/openejb/container/openejb-core/src/main: java/org/apache/openejb/config/AnnotationDeployer.java resources/org/apache/openejb/config/rules/Messages.properties

Author: rmannibucau
Date: Mon Jun  4 20:10:23 2012
New Revision: 1346137

URL: http://svn.apache.org/viewvc?rev=1346137&view=rev
Log:
OPENEJB-1836 specialize warning message for @Local on local bean

Modified:
    openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java
    openejb/trunk/openejb/container/openejb-core/src/main/resources/org/apache/openejb/config/rules/Messages.properties

Modified: openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java
URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java?rev=1346137&r1=1346136&r2=1346137&view=diff
==============================================================================
--- openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java (original)
+++ openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java Mon Jun  4 20:10:23 2012
@@ -2799,7 +2799,7 @@ public class AnnotationDeployer implemen
                         // just warn for @Local since Glassfish supports it even if it is weird
                         // still fail for @Remote!
                         if (impliedLocal && local.value().length == 0 && interfaces.size() == 0 && !strict) {
-                            validation.warn(ejbName, "ann.local.noAttributes", join(", ", interfaceNames));
+                            validation.warn(ejbName, "ann.local.forLocalBean", join(", ", interfaceNames));
                             // we don't go out to let be deployed
                         } else if (impliedLocal) {
                             validation.fail(ejbName, "ann.local.noAttributes", join(", ", interfaceNames));

Modified: openejb/trunk/openejb/container/openejb-core/src/main/resources/org/apache/openejb/config/rules/Messages.properties
URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/src/main/resources/org/apache/openejb/config/rules/Messages.properties?rev=1346137&r1=1346136&r2=1346137&view=diff
==============================================================================
--- openejb/trunk/openejb/container/openejb-core/src/main/resources/org/apache/openejb/config/rules/Messages.properties (original)
+++ openejb/trunk/openejb/container/openejb-core/src/main/resources/org/apache/openejb/config/rules/Messages.properties Mon Jun  4 20:10:23 2012
@@ -334,6 +334,11 @@
 #2.ann.remoteLocal.conflict = @Remote annotation in bean class conflicts with @Local in interface "{0}".
 #3.ann.remoteLocal.conflict = When annotating a bean class as @Remote, the corresponding business interfaces cannot be annotated with @Local.  Revise the business interface "{0}".
 
+# fail(ejbName, "ann.local.forLocalBean", join(", ", interfaces));
+1.ann.local.forLocalBean = @Local on a bean which doesn't implement an interface.
+2.ann.local.forLocalBean = @Local on a bean which doesn't implement an interface. Use @LocalBean instead.
+3.ann.local.forLocalBean = @Local marks an interface used locally. If you bean doesn't aim any interface use @localBean instead.
+
 # fail(ejbName, "ann.local.noAttributes", join(", ", interfaces));
 1.ann.local.noAttributes = Ambiguous @Local() usage on bean class
 2.ann.local.noAttributes = Ambiguous @Local() usage on bean class.  Must list interfaces explicitly in annotation.