You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Aaron Mulder <am...@alumni.princeton.edu> on 2006/03/23 15:08:20 UTC
Thoughts on renaming util module
Starting an e-mail thread aside from the JIRA...
I would *really* like to rename the util module. It's got our
bouncycastle import, plus some random Geronimo code dealing with
encryption and certificates.
I believe the best name for it is "crypto". John pointed out that
that isn't the greatest name since ASN1 and encoders such as Base64
aren't necessarily crypto. But this package deals with encryption,
decryptions, digests, PKI and certificates, etc. The bouncycastle
mailing lists are dev-crypto and accounce-crypto. I think the
"crypto" name, even if not perfect, fits much better than the "util"
name (which to me implies a general utility library like String
utilities, etc.). If necessary, I'd go as far as moving encoders to
the common module just to be able to give this one a better name,
because it does seem quite focused to me and not at all general.
Could we get more thoughts on this?
Thanks,
Aaron
Re: Thoughts on renaming util module
Posted by Rick McGuire <ri...@gmail.com>.
Guillaume Nodet wrote:
> Btw,some of this stuff has been duplicated in javamail spec, see
> http://svn.apache.org/repos/asf/geronimo/specs/trunk/geronimo-spec-javamail/src/main/java/org/apache/geronimo/mail/util/
>
That was intentional, to allow the javamail code to be used separately
from the rest of Geronimo, and also not have the spec jar files have
dependencies pointing back into the Geronimo code. If only Sun would
ever byte the bullet and add some of these frequently duplicated
encoders to the base JVM.
Rick
>
> Guillaume Nodet
>
> Vamsavardhana Reddy wrote:
>
>> "crypto" should be ok. Though ASN1, Base64 etc aren't necessarily
>> crypto, they are mostly used when dealing with crypto related stuff.
>>
>> -Vamsi
>>
>> On 3/23/06, *Aaron Mulder* <ammulder@alumni.princeton.edu
>> <ma...@alumni.princeton.edu>> wrote:
>>
>> Starting an e-mail thread aside from the JIRA...
>>
>> I would *really* like to rename the util module. It's got our
>> bouncycastle import, plus some random Geronimo code dealing with
>> encryption and certificates.
>>
>> I believe the best name for it is "crypto". John pointed out that
>> that isn't the greatest name since ASN1 and encoders such as Base64
>> aren't necessarily crypto. But this package deals with encryption,
>> decryptions, digests, PKI and certificates, etc. The bouncycastle
>> mailing lists are dev-crypto and accounce-crypto. I think the
>> "crypto" name, even if not perfect, fits much better than the "util"
>> name (which to me implies a general utility library like String
>> utilities, etc.). If necessary, I'd go as far as moving encoders to
>> the common module just to be able to give this one a better name,
>> because it does seem quite focused to me and not at all general.
>>
>> Could we get more thoughts on this?
>>
>> Thanks,
>> Aaron
>>
>>
>
Re: Thoughts on renaming util module
Posted by Guillaume Nodet <gu...@worldonline.fr>.
Btw,some of this stuff has been duplicated in javamail spec, see
http://svn.apache.org/repos/asf/geronimo/specs/trunk/geronimo-spec-javamail/src/main/java/org/apache/geronimo/mail/util/
Guillaume Nodet
Vamsavardhana Reddy wrote:
> "crypto" should be ok. Though ASN1, Base64 etc aren't necessarily
> crypto, they are mostly used when dealing with crypto related stuff.
>
> -Vamsi
>
> On 3/23/06, *Aaron Mulder* <ammulder@alumni.princeton.edu
> <ma...@alumni.princeton.edu>> wrote:
>
> Starting an e-mail thread aside from the JIRA...
>
> I would *really* like to rename the util module. It's got our
> bouncycastle import, plus some random Geronimo code dealing with
> encryption and certificates.
>
> I believe the best name for it is "crypto". John pointed out that
> that isn't the greatest name since ASN1 and encoders such as Base64
> aren't necessarily crypto. But this package deals with encryption,
> decryptions, digests, PKI and certificates, etc. The bouncycastle
> mailing lists are dev-crypto and accounce-crypto. I think the
> "crypto" name, even if not perfect, fits much better than the "util"
> name (which to me implies a general utility library like String
> utilities, etc.). If necessary, I'd go as far as moving encoders to
> the common module just to be able to give this one a better name,
> because it does seem quite focused to me and not at all general.
>
> Could we get more thoughts on this?
>
> Thanks,
> Aaron
>
>
Re: Thoughts on renaming util module
Posted by Vamsavardhana Reddy <c1...@gmail.com>.
"crypto" should be ok. Though ASN1, Base64 etc aren't necessarily crypto,
they are mostly used when dealing with crypto related stuff.
-Vamsi
On 3/23/06, Aaron Mulder <am...@alumni.princeton.edu> wrote:
>
> Starting an e-mail thread aside from the JIRA...
>
> I would *really* like to rename the util module. It's got our
> bouncycastle import, plus some random Geronimo code dealing with
> encryption and certificates.
>
> I believe the best name for it is "crypto". John pointed out that
> that isn't the greatest name since ASN1 and encoders such as Base64
> aren't necessarily crypto. But this package deals with encryption,
> decryptions, digests, PKI and certificates, etc. The bouncycastle
> mailing lists are dev-crypto and accounce-crypto. I think the
> "crypto" name, even if not perfect, fits much better than the "util"
> name (which to me implies a general utility library like String
> utilities, etc.). If necessary, I'd go as far as moving encoders to
> the common module just to be able to give this one a better name,
> because it does seem quite focused to me and not at all general.
>
> Could we get more thoughts on this?
>
> Thanks,
> Aaron
>
Re: Thoughts on renaming util module
Posted by "Alan D. Cabrera" <li...@toolazydogs.com>.
John Sisson wrote, On 3/23/2006 2:33 PM:
> Aaron Mulder wrote:
>
>> Starting an e-mail thread aside from the JIRA...
>>
>> I would *really* like to rename the util module. It's got our
>> bouncycastle import, plus some random Geronimo code dealing with
>> encryption and certificates.
>>
>> I believe the best name for it is "crypto". John pointed out that
>> that isn't the greatest name since ASN1 and encoders such as Base64
>> aren't necessarily crypto. But this package deals with encryption,
>> decryptions, digests, PKI and certificates, etc. The bouncycastle
>> mailing lists are dev-crypto and accounce-crypto. I think the
>> "crypto" name, even if not perfect, fits much better than the "util"
>> name (which to me implies a general utility library like String
>> utilities, etc.). If necessary, I'd go as far as moving encoders to
>> the common module just to be able to give this one a better name,
>> because it does seem quite focused to me and not at all general.
>>
>> Could we get more thoughts on this?
>>
>> Thanks,
>> Aaron
>>
>>
>
> I was also concerned that if people see a crypto module they will
> think that Geronimo has its own crypto implementation (which AFAIK is
> not the case).
>
> Users that think we have a crypto implementation may then become
> worried about government crypto export/import licenses etc.
>
> Not sure if crypto-interface is much clearer.
crypto-support?
Regards,
Alan
Re: Thoughts on renaming util module
Posted by Jason Dillon <ja...@planet57.com>.
Can't say I really like 'crypto-interface' too much... I'm not too
concerned about confusing users either... but maybe I should be.
--jason
On 3/23/06, John Sisson <jr...@gmail.com> wrote:
> Aaron Mulder wrote:
> > Starting an e-mail thread aside from the JIRA...
> >
> > I would *really* like to rename the util module. It's got our
> > bouncycastle import, plus some random Geronimo code dealing with
> > encryption and certificates.
> >
> > I believe the best name for it is "crypto". John pointed out that
> > that isn't the greatest name since ASN1 and encoders such as Base64
> > aren't necessarily crypto. But this package deals with encryption,
> > decryptions, digests, PKI and certificates, etc. The bouncycastle
> > mailing lists are dev-crypto and accounce-crypto. I think the
> > "crypto" name, even if not perfect, fits much better than the "util"
> > name (which to me implies a general utility library like String
> > utilities, etc.). If necessary, I'd go as far as moving encoders to
> > the common module just to be able to give this one a better name,
> > because it does seem quite focused to me and not at all general.
> >
> > Could we get more thoughts on this?
> >
> > Thanks,
> > Aaron
> >
> >
> I was also concerned that if people see a crypto module they will think
> that Geronimo has its own crypto implementation (which AFAIK is not the
> case).
>
> Users that think we have a crypto implementation may then become worried
> about government crypto export/import licenses etc.
>
> Not sure if crypto-interface is much clearer.
>
> Regards,
>
> John
>
Re: Thoughts on renaming util module
Posted by John Sisson <jr...@gmail.com>.
Aaron Mulder wrote:
> Starting an e-mail thread aside from the JIRA...
>
> I would *really* like to rename the util module. It's got our
> bouncycastle import, plus some random Geronimo code dealing with
> encryption and certificates.
>
> I believe the best name for it is "crypto". John pointed out that
> that isn't the greatest name since ASN1 and encoders such as Base64
> aren't necessarily crypto. But this package deals with encryption,
> decryptions, digests, PKI and certificates, etc. The bouncycastle
> mailing lists are dev-crypto and accounce-crypto. I think the
> "crypto" name, even if not perfect, fits much better than the "util"
> name (which to me implies a general utility library like String
> utilities, etc.). If necessary, I'd go as far as moving encoders to
> the common module just to be able to give this one a better name,
> because it does seem quite focused to me and not at all general.
>
> Could we get more thoughts on this?
>
> Thanks,
> Aaron
>
>
I was also concerned that if people see a crypto module they will think
that Geronimo has its own crypto implementation (which AFAIK is not the
case).
Users that think we have a crypto implementation may then become worried
about government crypto export/import licenses etc.
Not sure if crypto-interface is much clearer.
Regards,
John
Re: Thoughts on renaming util module
Posted by "Alan D. Cabrera" <li...@toolazydogs.com>.
Aaron Mulder wrote, On 3/23/2006 7:07 AM:
>On 3/23/06, Rick McGuire <ri...@gmail.com> wrote:
>
>
>>The "random Geromino" code is all part of the original bounycastle
>>import, I believe.
>>
>>
>
>That's not entirely correct -- there's our utility classes for
>encrypting passwords in config files and I have some
>soon-to-be-committed changes adding certificate helper code like
>generating a formatted fingerprint (MD5 hash).
>
>
>
>>The code that is in this package is all of the bits from bouncycastle
>>necessary to support the asn1 functions required by openejb. Anything
>>not in the asn1 subdir is just a class needed by the asn1 code, so
>>perhaps a better package name would be asn1 (with some appropriate
>>reorganization).
>>
>>
>
>But it's also used by our keystore implementation, which is (or should
>be) fundamental to any SSL networking in the web container, EJB
>container, JMS, etc., etc., etc. I am also in the process of making
>the keystore logic more central to Geronimo and moving toward a
>central service that will provide SSL server socket factories, and
>that will all leverage this library, so between the password
>encryption and that, I don't terribly fancy calling it ASN1.
>
>
Crytpo works for me. The ASN1 code is solely for the crypto support.
Hiding that stuff there is a good idea imo.
Regards,
Alan
Re: Thoughts on renaming util module
Posted by Aaron Mulder <am...@alumni.princeton.edu>.
On 3/23/06, Rick McGuire <ri...@gmail.com> wrote:
> The "random Geromino" code is all part of the original bounycastle
> import, I believe.
That's not entirely correct -- there's our utility classes for
encrypting passwords in config files and I have some
soon-to-be-committed changes adding certificate helper code like
generating a formatted fingerprint (MD5 hash).
> The code that is in this package is all of the bits from bouncycastle
> necessary to support the asn1 functions required by openejb. Anything
> not in the asn1 subdir is just a class needed by the asn1 code, so
> perhaps a better package name would be asn1 (with some appropriate
> reorganization).
But it's also used by our keystore implementation, which is (or should
be) fundamental to any SSL networking in the web container, EJB
container, JMS, etc., etc., etc. I am also in the process of making
the keystore logic more central to Geronimo and moving toward a
central service that will provide SSL server socket factories, and
that will all leverage this library, so between the password
encryption and that, I don't terribly fancy calling it ASN1.
Thanks,
Aaron
Re: Thoughts on renaming util module
Posted by Rick McGuire <ri...@gmail.com>.
Aaron Mulder wrote:
> Starting an e-mail thread aside from the JIRA...
>
> I would *really* like to rename the util module. It's got our
> bouncycastle import, plus some random Geronimo code dealing with
> encryption and certificates.
>
The "random Geromino" code is all part of the original bounycastle
import, I believe.
> I believe the best name for it is "crypto". John pointed out that
> that isn't the greatest name since ASN1 and encoders such as Base64
> aren't necessarily crypto. But this package deals with encryption,
> decryptions, digests, PKI and certificates, etc. The bouncycastle
> mailing lists are dev-crypto and accounce-crypto. I think the
> "crypto" name, even if not perfect, fits much better than the "util"
> name (which to me implies a general utility library like String
> utilities, etc.). If necessary, I'd go as far as moving encoders to
> the common module just to be able to give this one a better name,
> because it does seem quite focused to me and not at all general.
>
I think I'd be in favor of that, or leaving the encoders/decoders in
util and splitting off the rest of the package. I see a lot more
general-purpose use for the encoders that for the rest of the package.
I'm not sure "crypto" is the best name for this package, because this is
really higher level functions above the actual crypto support. The
imported code doesn't directly implement any crypto functions, but it
definitely takes advantage of it (even the files in the "crypto"
subpackage don't really have anything directly to do with
cryptography...they're just interface classes).
The code that is in this package is all of the bits from bouncycastle
necessary to support the asn1 functions required by openejb. Anything
not in the asn1 subdir is just a class needed by the asn1 code, so
perhaps a better package name would be asn1 (with some appropriate
reorganization).
> Could we get more thoughts on this?
>
> Thanks,
> Aaron
>
>