You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Kristine Hahn (Code Review)" <ge...@cloudera.org> on 2020/03/18 18:25:46 UTC

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete 

Kristine Hahn has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15476


Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................

IMPALA-9443: [DOCS] Make tables optically pleasing and complete

- Replaced ellipses in example columns with sample output
- Fixed table formatting problems

Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
---
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_show.xml
2 files changed, 95 insertions(+), 96 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/15476/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15476 )

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 4
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Mar 2020 06:39:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Kristine Hahn (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15476

to look at the new patch set (#4).

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................

IMPALA-9443: [DOCS] Make tables optically pleasing and complete

- Replaced ellipses in example columns with sample output
- Fixed table formatting problems

Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
---
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_show.xml
2 files changed, 97 insertions(+), 96 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/15476/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 4
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15476 )

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/569/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2020 18:34:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15476 )

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................


Patch Set 3: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/571/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 3
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2020 20:29:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Kristine Hahn (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15476

to look at the new patch set (#3).

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................

IMPALA-9443: [DOCS] Make tables optically pleasing and complete

- Replaced ellipses in example columns with sample output
- Fixed table formatting problems

Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
---
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_show.xml
2 files changed, 96 insertions(+), 99 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/15476/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 3
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15476 )

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................


Patch Set 4: Code-Review+1

Actually I think Tamas should take a look just to make sure that this caught all the problems he saw.


-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 4
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Mar 2020 06:42:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15476 )

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 5
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 21:14:30 +0000
Gerrit-HasComments: No

Re: [Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by Kristine Hahn <kh...@cloudera.com.INVALID>.
Some of the formatting problems in the currently published doc are due to
using styles in codeblocks. A WYSIWYG view of tables is needed to
efficiently maintain the docs. We don't build the DITA docs locally, so it
seems impossible to maintain tables that use styles. How about removing
angle bracket codes that I suggested and just using names that are
obviously variables, like myserver?

On Thu, Mar 19, 2020 at 2:40 AM Tamas Mate (Code Review) <
gerrit@cloudera.org> wrote:

> Tamas Mate *posted comments* on this change.
>
> View Change <http://gerrit.cloudera.org:8080/15476>
>
> Patch set 4:
>
> Thanks for adding me, it is looks better now. Noticed a style change and 2
> tables left where the formatting is not correct at the moment, these are
> related with the style change.
>
> I can see that <varname> was replaced with '&lt;' and '&gt;' in some
> places. In general <varname> is used to describe variables in Impala
> documentation, although there are few cases where there are '&lt;' and
> '&gt;'. I think we should go with the <varname> tags.
>
> These are the two commands that I used to check which annotation is used
> to mark variables, should be executed in this directory:
> 'Impala/docs/topics'
> grep -n "&lt;.*&gt;" ./*
> grep -n "<varname>.*</varname>" ./*
>
> (2 comments)
>
>    -
>
>    File docs/topics/impala_show.xml:
>    <http://gerrit.cloudera.org:8080/#/c/15476/4/docs/topics/impala_show.xml>
>    -
>
>       Patch Set #4, Line 292:
>       <ht...@292>
>       -------------------
>
>       The <varname> tags are translated to italic, therefore the extra
>       dashes are not needed on this table.
>       -
>
>       Patch Set #4, Line 831:
>       <ht...@831>
>       ------
>
>       Because the &lt and &gt are displayed as < and > in the browser,
>       this header should be 6 dashes shorter.
>
> To view, visit change 15476 <http://gerrit.cloudera.org:8080/15476>. To
> unsubscribe, visit settings <http://gerrit.cloudera.org:8080/settings>.
> Gerrit-Project: Impala-ASF
> Gerrit-Branch: master
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
> Gerrit-Change-Number: 15476
> Gerrit-PatchSet: 4
> Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
> Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
>
> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
> Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
> Gerrit-Comment-Date: Thu, 19 Mar 2020 09:40:27 +0000
> Gerrit-HasComments: Yes
>


-- 
Kris Hahn
415-497-8107

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/15476 )

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................


Patch Set 4:

(2 comments)

Thanks for adding me, it is looks better now. Noticed a style change and 2 tables left where the formatting is not correct at the moment, these are related with the style change.

I can see that <varname> was replaced with '&lt;' and '&gt;' in some places. In general <varname> is used to describe variables in Impala documentation, although there are few cases where there are '&lt;' and '&gt;'. I think we should go with the <varname> tags.

These are the two commands that I used to check which annotation is used to mark variables, should be executed in this directory: 'Impala/docs/topics'
grep -n "&lt;.*&gt;" ./*
grep -n "<varname>.*</varname>" ./*

http://gerrit.cloudera.org:8080/#/c/15476/4/docs/topics/impala_show.xml
File docs/topics/impala_show.xml:

http://gerrit.cloudera.org:8080/#/c/15476/4/docs/topics/impala_show.xml@292
PS4, Line 292: -------------------
The <varname> tags are translated to italic, therefore the extra dashes are not needed on this table.


http://gerrit.cloudera.org:8080/#/c/15476/4/docs/topics/impala_show.xml@831
PS4, Line 831: ------
Because the &lt and &gt are displayed as < and > in the browser, this header should be 6 dashes shorter.



-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 4
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Mar 2020 09:40:27 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15476 )

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................


Patch Set 4: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/572/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 4
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2020 21:36:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15476 )

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................


Patch Set 4:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/572/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 4
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2020 21:29:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Kristine Hahn (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Tim Armstrong, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15476

to look at the new patch set (#5).

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................

IMPALA-9443: [DOCS] Make tables optically pleasing and complete

- Replaced ellipses in example columns with sample output
- Fixed table formatting problems
- Exhumed varname styles
- Reverted table formatting at line 292 to published version formatting
- Fixed table formatting at 831

Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
---
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_show.xml
2 files changed, 90 insertions(+), 89 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/15476/5
-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 5
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15476 )

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................

IMPALA-9443: [DOCS] Make tables optically pleasing and complete

- Replaced ellipses in example columns with sample output
- Fixed table formatting problems
- Exhumed varname styles
- Reverted table formatting at line 292 to published version formatting
- Fixed table formatting at 831

Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Reviewed-on: http://gerrit.cloudera.org:8080/15476
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_show.xml
2 files changed, 90 insertions(+), 89 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 6
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15476 )

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/571/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 3
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2020 20:20:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15476 )

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................


Patch Set 5: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/573/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 5
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Mar 2020 20:17:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Kristine Hahn (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15476

to look at the new patch set (#2).

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................

IMPALA-9443: [DOCS] Make tables optically pleasing and complete

- Replaced ellipses in example columns with sample output
- Fixed table formatting problems

Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
(cherry picked from commit 82ffc9ab96f5ac6ef418c362ac38189a4a722d97)
---
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_show.xml
2 files changed, 95 insertions(+), 96 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/15476/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 2
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15476 )

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/569/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2020 18:25:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Kristine Hahn (Code Review)" <ge...@cloudera.org>.
Kristine Hahn has removed Tamas Mate from this change.  ( http://gerrit.cloudera.org:8080/15476 )

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................


Removed reviewer Tamas Mate.
-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 3
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9443: [DOCS] Make tables optically pleasing and complete

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15476 )

Change subject: IMPALA-9443: [DOCS] Make tables optically pleasing and complete
......................................................................


Patch Set 5:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/573/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/15476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83fd30b87730c82c87f6f7aee26d8cceb77b6308
Gerrit-Change-Number: 15476
Gerrit-PatchSet: 5
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Mar 2020 20:10:14 +0000
Gerrit-HasComments: No