You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/07/20 04:46:37 UTC
[GitHub] [druid] suneet-s commented on a change in pull request #11450: Web console: better handle BigInt math
suneet-s commented on a change in pull request #11450:
URL: https://github.com/apache/druid/pull/11450#discussion_r672802079
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -1141,10 +1142,10 @@ ORDER BY 1`;
day_aligned_segments,
month_aligned_segments,
year_aligned_segments,
- } = original;
+ } = original as Datasource;
const segmentGranularities: string[] = [];
if (!num_segments || isNaN(year_aligned_segments)) return '-';
- if (num_segments - minute_aligned_segments) {
+ if (Number(num_segments) - minute_aligned_segments) {
Review comment:
should this be cast to `NumberLike` because of line 156?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org