You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/03/01 03:38:30 UTC
[GitHub] [kylin] liukun4515 opened a new pull request #1592: [KYLIN-4920]real-time stream support diff database hive table in lambda mode
liukun4515 opened a new pull request #1592:
URL: https://github.com/apache/kylin/pull/1592
## Proposed changes
[KYLIN-4920](https://issues.apache.org/jira/browse/KYLIN-4920)
User can define stream lambda table in diff database.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] liukun4515 commented on pull request #1592: [KYLIN-4920]real-time stream support diff database hive table in lambda mode
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on pull request #1592:
URL: https://github.com/apache/kylin/pull/1592#issuecomment-787613461
@hit-lacus PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls commented on pull request #1592: [KYLIN-4920]real-time stream support diff database hive table in lambda mode
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1592:
URL: https://github.com/apache/kylin/pull/1592#issuecomment-787621747
## Pull Request Test Coverage Report for [Build 6908](https://coveralls.io/builds/37518932)
* **0** of **1** **(0.0%)** changed or added relevant line in **1** file are covered.
* **9** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-0.0008%**) to **27.954%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [server-base/src/main/java/org/apache/kylin/rest/controller/StreamingV2Controller.java](https://coveralls.io/builds/37518932/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FStreamingV2Controller.java#L520) | 0 | 1 | 0.0%
<!-- | **Total:** | **0** | **1** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [server-base/src/main/java/org/apache/kylin/rest/controller/StreamingV2Controller.java](https://coveralls.io/builds/37518932/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FStreamingV2Controller.java#L504) | 1 | 0% |
| [tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/37518932/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42) | 1 | 81.58% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/37518932/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/37518932/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
<!-- | **Total:** | **9** | | -->
| Totals | [](https://coveralls.io/builds/37518932) |
| :-- | --: |
| Change from base [Build 6896](https://coveralls.io/builds/37334768): | -0.0008% |
| Covered Lines: | 26255 |
| Relevant Lines: | 93921 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1592: [KYLIN-4920]real-time stream support diff database hive table in lambda mode
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1592:
URL: https://github.com/apache/kylin/pull/1592#issuecomment-787688003
Could you please explain, in which way should user configure database of lambda cube use? In front-end page?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-io commented on pull request #1592: [KYLIN-4920]real-time stream support diff database hive table in lambda mode
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1592:
URL: https://github.com/apache/kylin/pull/1592#issuecomment-787621018
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1592?src=pr&el=h1) Report
> Merging [#1592](https://codecov.io/gh/apache/kylin/pull/1592?src=pr&el=desc) (1c59a3e) into [master](https://codecov.io/gh/apache/kylin/commit/af1e59f6e96201b6a6c4912204ff7faa2ec10d5d?el=desc) (af1e59f) will **decrease** coverage by `0.10%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/kylin/pull/1592?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1592 +/- ##
============================================
- Coverage 25.51% 25.41% -0.11%
+ Complexity 6762 6761 -1
============================================
Files 1505 1508 +3
Lines 93600 93921 +321
Branches 13103 13159 +56
============================================
- Hits 23884 23866 -18
- Misses 67342 67670 +328
- Partials 2374 2385 +11
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1592?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/kylin/rest/controller/StreamingV2Controller.java](https://codecov.io/gh/apache/kylin/pull/1592/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9TdHJlYW1pbmdWMkNvbnRyb2xsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../apache/kylin/tool/query/ProbabilityGenerator.java](https://codecov.io/gh/apache/kylin/pull/1592/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9xdWVyeS9Qcm9iYWJpbGl0eUdlbmVyYXRvci5qYXZh) | `71.05% <0.00%> (-5.27%)` | `11.00% <0.00%> (ø%)` | |
| [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1592/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | |
| [...che/kylin/stream/core/storage/CheckPointStore.java](https://codecov.io/gh/apache/kylin/pull/1592/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvQ2hlY2tQb2ludFN0b3JlLmphdmE=) | `63.63% <0.00%> (-3.04%)` | `21.00% <0.00%> (-1.00%)` | |
| [...n/java/org/apache/kylin/common/util/ClassUtil.java](https://codecov.io/gh/apache/kylin/pull/1592/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0NsYXNzVXRpbC5qYXZh) | `49.20% <0.00%> (-2.47%)` | `9.00% <0.00%> (ø%)` | |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1592/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | |
| [...va/org/apache/kylin/tool/query/QueryGenerator.java](https://codecov.io/gh/apache/kylin/pull/1592/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9xdWVyeS9RdWVyeUdlbmVyYXRvci5qYXZh) | `78.88% <0.00%> (-2.23%)` | `22.00% <0.00%> (-2.00%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1592/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.30% <0.00%> (-1.83%)` | `7.00% <0.00%> (ø%)` | |
| [...rg/apache/kylin/source/jdbc/JdbcHiveInputBase.java](https://codecov.io/gh/apache/kylin/pull/1592/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL0pkYmNIaXZlSW5wdXRCYXNlLmphdmE=) | `7.92% <0.00%> (-1.14%)` | `7.00% <0.00%> (ø%)` | |
| [...a/org/apache/kylin/dict/TrieDictionaryBuilder.java](https://codecov.io/gh/apache/kylin/pull/1592/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L1RyaWVEaWN0aW9uYXJ5QnVpbGRlci5qYXZh) | `80.49% <0.00%> (-0.87%)` | `46.00% <0.00%> (+2.00%)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/kylin/pull/1592/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1592?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1592?src=pr&el=footer). Last update [af1e59f...1c59a3e](https://codecov.io/gh/apache/kylin/pull/1592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] liukun4515 commented on pull request #1592: [KYLIN-4920]real-time stream support diff database hive table in lambda mode
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on pull request #1592:
URL: https://github.com/apache/kylin/pull/1592#issuecomment-787725209
> Could you please explain, in which way should user configure database of lambda cube use? In front-end page?
Update the PR message.
If the database name in hive is `hive_database`, user should just add the prefix before the table name, just like `hive_database.your_table_name` .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1592: [KYLIN-4920]real-time stream support diff database hive table in lambda mode
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1592:
URL: https://github.com/apache/kylin/pull/1592
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org