You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2014/10/02 02:04:01 UTC
Re: Review Request 25818: Switch path::join() to be variadic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25818/#review55162
-----------------------------------------------------------
Ship it!
Looks great. I can add the blank line and commit it.
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp
<https://reviews.apache.org/r/25818/#comment95547>
Nit: Put a blank line before this comment too.
- Adam B
On Sept. 29, 2014, 11:01 a.m., Cody Maloney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25818/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 11:01 a.m.)
>
>
> Review request for mesos, Adam B and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Switch path::join() to be variadic.
>
> Updated now that 25789 has landed
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 2ee5a0b
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp bc6920a
> 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 14567f1
> 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25818/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Cody Maloney
>
>