[GitHub] [superset] michael-s-molina commented on pull request #16851: fix(dashboard): Fill form with the latest values when undo in native filters

[GitBox <gi...@apache.org>]

michael-s-molina commented on pull request #16851:
URL: https://github.com/apache/superset/pull/16851#issuecomment-927776730


   @geido If I'm not mistaken when the user removes a filter, it only marks that filter as deleted but the form values are preserved. If that's the case, why do we need the `undoFormValues` state? Can't we just use the original form?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org