[jira] [Comment Edited] (ATLAS-2310) In HA, the passive node redirects the request with wrong URL encoding

["Madhan Neethiraj (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ATLAS-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318111#comment-16318111 ] 

Madhan Neethiraj edited comment on ATLAS-2310 at 1/12/18 3:08 AM:
------------------------------------------------------------------

Thanks [~pbarna] for the patch and [~ruchi_solani] for review.

Committed patch 
* master :- http://git-wip-us.apache.org/repos/asf/atlas/commit/4dc95339
* branch-0.8: http://git-wip-us.apache.org/repos/asf/atlas/commit/52ecc674


was (Author: nixonrodrigues):
Thanks [~pbarna] for the patch and [~ruchi_solani] for review.

Committed patch 
* master :- http://git-wip-us.apache.org/repos/asf/atlas/commit/4dc95339

> In HA, the passive node redirects the request with wrong URL encoding 
> ----------------------------------------------------------------------
>
>                 Key: ATLAS-2310
>                 URL: https://issues.apache.org/jira/browse/ATLAS-2310
>             Project: Atlas
>          Issue Type: Bug
>    Affects Versions: 0.8.1
>            Reporter: Péter Gergő Barna
>            Assignee: Péter Gergő Barna
>             Fix For: 1.0.0, 0.8.2
>
>         Attachments: ATLAS-2310.patch
>
>
> In HA, the passive node redirects the request with wrong URL encoding. Instead of encoding only the values, the whole query is encoded as a single string.
> url = "http://atlas.node.com:21000/api/atlas/entites?type=My type&name=My name"
> wrong result after encoding:
> http://atlas.node.com:21000/api/atlas/entites?type%3DMy+type%26name%3DMy+name
> expected result after encoding:
> http://atlas.node.com:21000/api/atlas/entites?type=My%20type&name=My%20name
> in the code, instead of https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java#L132
> {noformat}
> queryString = URLEncoder.encode(queryString, "UTF-8");
> {noformat}
> we should do something like 
> {noformat}
> import org.springframework.web.util.UriUtils
> queryString = UriUtils.encodeQuery(queryString, "UTF-8")
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)