You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Henning Schmiedehausen (JIRA)" <ji...@codehaus.org> on 2007/01/28 16:24:44 UTC
[jira] Created: (MCHANGES-66) The changes plugin scatters white
space over its Changes report
The changes plugin scatters white space over its Changes report
---------------------------------------------------------------
Key: MCHANGES-66
URL: http://jira.codehaus.org/browse/MCHANGES-66
Project: Maven 2.x Changes Plugin
Issue Type: Bug
Reporter: Henning Schmiedehausen
Attachments: changes4.patch
The changelog plugin reads the contents of the changes.xml file and scatters \n characters into it. The attached patch fixes this and also improves performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHANGES-66) The changes plugin scatters white
space over its Changes report
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MCHANGES-66:
--------------------------------------
Attachment: sax-parsing.patch
changes.xml
Dennis, here is the changes.xml you requested. To see the unwanted newlines, checkout for lines that are longer than the others in the generated changes report.
Attached is another try for a patch. It's a variation of Henning's first patch. To my knowledge, a SAX parser may split the input strings at ANY position when reporting character chunks (see also [Top Ten SAX2 Tips|http://www.xml.com/pub/a/2001/12/05/sax2.html#d0e56]). For instance, the string "Word" may be reported as the two chunks "Wo" and "rd" (that's why inserting a newline after each chunk is a bad idea). Likewise, it might happen that the string "Two Words" gets reported as "Two", " " and "Words" (that's why trimming the chunks before concatenation is a bad idea because it would yield "TwoWords"). So whatever string transformations the plugin needs, it should be done at the end after the entire input string has been read and reconstructed.
> The changes plugin scatters white space over its Changes report
> ---------------------------------------------------------------
>
> Key: MCHANGES-66
> URL: http://jira.codehaus.org/browse/MCHANGES-66
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Reporter: Henning Schmiedehausen
> Assignee: Dennis Lundberg
> Attachments: changes.xml, changes4.patch, changes7.patch, sax-parsing.patch
>
>
> The changelog plugin reads the contents of the changes.xml file and scatters \n characters into it. The attached patch fixes this and also improves performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHANGES-66) The changes plugin scatters white
space over its Changes report
Posted by "Henning Schmiedehausen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henning Schmiedehausen updated MCHANGES-66:
-------------------------------------------
Attachment: changes7.patch
That patch is even a bit better, because it also passes XML tags that are part of the various fields through to the output. The old Maven-1 plugin allowed e.g. to have links or <code> fields inside the action texts. This patch now also restores this behaviour.
> The changes plugin scatters white space over its Changes report
> ---------------------------------------------------------------
>
> Key: MCHANGES-66
> URL: http://jira.codehaus.org/browse/MCHANGES-66
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Reporter: Henning Schmiedehausen
> Attachments: changes4.patch, changes7.patch
>
>
> The changelog plugin reads the contents of the changes.xml file and scatters \n characters into it. The attached patch fixes this and also improves performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MCHANGES-66) The changes plugin
scatters white space over its Changes report
Posted by "Henning Schmiedehausen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_120838 ]
hgschmie edited comment on MCHANGES-66 at 1/22/08 4:20 AM:
-------------------------------------------------------------------------
<offending comment deleted>.
Apologies to Dennis, this venting of steam actually hit the wrong person (because he is one of the few that actually cares for the open issues against maven plugin).
was (Author: hgschmie):
51 weeks and one day after the initial bug report, a new snapshot has been deployed. I'm really impressed.
> The changes plugin scatters white space over its Changes report
> ---------------------------------------------------------------
>
> Key: MCHANGES-66
> URL: http://jira.codehaus.org/browse/MCHANGES-66
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Reporter: Henning Schmiedehausen
> Assignee: Dennis Lundberg
> Fix For: 2.0-beta-4
>
> Attachments: changes-report.html, changes.xml, changes4.patch, changes7.patch, MCHANGES-66.zip, sax-parsing.patch
>
>
> The changelog plugin reads the contents of the changes.xml file and scatters \n characters into it. The attached patch fixes this and also improves performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-66) The changes plugin scatters white
space over its Changes report
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_86676 ]
Stephane Nicoll commented on MCHANGES-66:
-----------------------------------------
The patch breaks some of my announcement so I need to look into it to fix it.
With a sample announcement, such as :
{code:xml}
<document>
<properties>
<title>Changes Tester Project</title>
<author email="jruiz@exist.com">Johnny R. Ruiz III</author>
</properties>
<body>
<release version="1.0" date="2005-01-01" description="First release">
<action dev="jruiz" type="update">
Uploaded documentation on how to use the plugin.
</action>
<action dev="jruiz" type="add">
Added additional documentation on how to configure the plugin.
</action>
<action dev="aramirez" type="fix" issue="MPJIRA-11">
Enable retrieving component-specific issues.
</action>
<action dev="jruiz" type="fix" due-to="Allan Ramirez" due-to-email="aramirez@exist.com">
The element type " link " must be terminated by the matching end-tag.
Deleted the erroneous code.
</action>
</release>
</body>
</document>
{code}
I got this:
{noformat}
The ejbs-team is pleased to announce the ejbs-1.0.ejb release!
http://www.blah.com
Changes in this version include:
New Features:
o Added additional documentation on how to configure the plugin.
Fixed Bugs:
o Enable retrieving component-specific issues. Issue: MPJIRA-11.
o The element type " link " must be terminated by the matching end-tag. Deleted the erroneous code. Thanks to Allan Ramirez.
Changes:
o </properties> Uploaded documentation on how to use the plugin.
Removed:
For a manual installation, you can download the ejbs-1.0.ejb here:
http://www.blah.com/ejbs-1.0.jar
Have fun!
-ejbs-team
{noformat}
> The changes plugin scatters white space over its Changes report
> ---------------------------------------------------------------
>
> Key: MCHANGES-66
> URL: http://jira.codehaus.org/browse/MCHANGES-66
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Reporter: Henning Schmiedehausen
> Assigned To: Stephane Nicoll
> Attachments: changes4.patch, changes7.patch
>
>
> The changelog plugin reads the contents of the changes.xml file and scatters \n characters into it. The attached patch fixes this and also improves performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-66) The changes plugin scatters white
space over its Changes report
Posted by "Henning Schmiedehausen (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_120838 ]
Henning Schmiedehausen commented on MCHANGES-66:
------------------------------------------------
51 weeks and one day after the initial bug report, a new snapshot has been deployed. I'm really impressed.
> The changes plugin scatters white space over its Changes report
> ---------------------------------------------------------------
>
> Key: MCHANGES-66
> URL: http://jira.codehaus.org/browse/MCHANGES-66
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Reporter: Henning Schmiedehausen
> Assignee: Dennis Lundberg
> Fix For: 2.0-beta-4
>
> Attachments: changes-report.html, changes.xml, changes4.patch, changes7.patch, MCHANGES-66.zip, sax-parsing.patch
>
>
> The changelog plugin reads the contents of the changes.xml file and scatters \n characters into it. The attached patch fixes this and also improves performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHANGES-66) The changes plugin scatters white
space over its Changes report
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MCHANGES-66:
--------------------------------------
Attachment: changes-report.html
Well, I tried 2.0-beta-3 as well as the current 2.0-beta-4-SNAPSHOT (build from source r611604), both embedded newlines as I expected. I attached the generated changes-report.html just that you can get a feel of it.
I previously tried to point out that the plugin currently misuses the SAX API (i.e. makes invalid assumptions about the parser callbacks). Please, consider the implications of the following quotation from the already mentioned "Top Ten SAX2 Tips":
bq. It'd be *legal* (but annoying) for the parser to report *one character per callback*
Also, see the final note in the paragraph "Handling events" from the [SAX Quickstart|http://www.saxproject.org/quickstart.html] or the related question in the [SAX FAQ|http://www.saxproject.org/faq.html]. The issue of unwanted newlines may be hard to reproduce but it is there.
Just for the fun of it, I extended the changes.xml to contain a really long line (only alphanum's so the browser won't wrap). In the resulting HTML output, I get a line break every 2048 characters... if I only had some money, I would bet this is the size of the parser's character buffer ;-) Dennis, maybe you can also reproduce this issue by yourself if you try a changes.xml with at least 8 KB or 16 KB character data in a line.
Apropos parsing: What happened to the efforcts in MCHANGES-47 to bring Modello into the game? If I understand Modello correctly, it frees the plugin developer from parsing, thereby reducing the chance for errors like this.
> The changes plugin scatters white space over its Changes report
> ---------------------------------------------------------------
>
> Key: MCHANGES-66
> URL: http://jira.codehaus.org/browse/MCHANGES-66
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Reporter: Henning Schmiedehausen
> Assignee: Dennis Lundberg
> Attachments: changes-report.html, changes.xml, changes4.patch, changes7.patch, MCHANGES-66.zip, sax-parsing.patch
>
>
> The changelog plugin reads the contents of the changes.xml file and scatters \n characters into it. The attached patch fixes this and also improves performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-66) The changes plugin scatters white
space over its Changes report
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_120839 ]
Dennis Lundberg commented on MCHANGES-66:
-----------------------------------------
That's an utterly disrespectful thing to say.
> The changes plugin scatters white space over its Changes report
> ---------------------------------------------------------------
>
> Key: MCHANGES-66
> URL: http://jira.codehaus.org/browse/MCHANGES-66
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Reporter: Henning Schmiedehausen
> Assignee: Dennis Lundberg
> Fix For: 2.0-beta-4
>
> Attachments: changes-report.html, changes.xml, changes4.patch, changes7.patch, MCHANGES-66.zip, sax-parsing.patch
>
>
> The changelog plugin reads the contents of the changes.xml file and scatters \n characters into it. The attached patch fixes this and also improves performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-66) The changes plugin scatters white
space over its Changes report
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_119862 ]
Dennis Lundberg commented on MCHANGES-66:
-----------------------------------------
Thanks for the tips Benjamin. I have now reproduced this. For me it occurs at around 8k of characters. Now that I have something to work with I'll try out your patch.
I'd also like to try out MCHANGES-47, but it depends on a new release of Modello. So I'm pushing to get that release done first.
> The changes plugin scatters white space over its Changes report
> ---------------------------------------------------------------
>
> Key: MCHANGES-66
> URL: http://jira.codehaus.org/browse/MCHANGES-66
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Reporter: Henning Schmiedehausen
> Assignee: Dennis Lundberg
> Attachments: changes-report.html, changes.xml, changes4.patch, changes7.patch, MCHANGES-66.zip, sax-parsing.patch
>
>
> The changelog plugin reads the contents of the changes.xml file and scatters \n characters into it. The attached patch fixes this and also improves performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-66) The changes plugin scatters white
space over its Changes report
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_119891 ]
Benjamin Bentmann commented on MCHANGES-66:
-------------------------------------------
The removal of line breaks is simply caused by
{code:java}
replace( '\n', ' ' )
{code}
which can be easily spotted in the patch and removed if required.
I adopted this behavior from Henning's patch which I considered useful as some kind of white-space normalization since one (at least me and my IDE) usually uses white-space in XML only for formatting of the XML input itself, and not for formatting of the output generated from the XML. Or is there any spec about the changes.xml that dictates to preserve white-space in certain elements?
If white-space normalization is OK, then however my patch should be further improved to deliver a proper normalization. I would define a proper normalization as
- no leading/trailing white-space (trim() in place)
- no consecutive white-space (missing)
- only 0x20 as white-space character (missing)
The last two aspects should be easily realizable via
{code:java}
replaceAll("\\s+", " ")
{code}
instead of the existing replace() calls.
> The changes plugin scatters white space over its Changes report
> ---------------------------------------------------------------
>
> Key: MCHANGES-66
> URL: http://jira.codehaus.org/browse/MCHANGES-66
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Reporter: Henning Schmiedehausen
> Assignee: Dennis Lundberg
> Attachments: changes-report.html, changes.xml, changes4.patch, changes7.patch, MCHANGES-66.zip, sax-parsing.patch
>
>
> The changelog plugin reads the contents of the changes.xml file and scatters \n characters into it. The attached patch fixes this and also improves performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MCHANGES-66) The changes plugin scatters white
space over its Changes report
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg closed MCHANGES-66.
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.0-beta-4
I have applied the patch, but I opted not to remove line breaks. Thanks!
A new SNAPSHOT has been deployed. Please give a try.
> The changes plugin scatters white space over its Changes report
> ---------------------------------------------------------------
>
> Key: MCHANGES-66
> URL: http://jira.codehaus.org/browse/MCHANGES-66
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Reporter: Henning Schmiedehausen
> Assignee: Dennis Lundberg
> Fix For: 2.0-beta-4
>
> Attachments: changes-report.html, changes.xml, changes4.patch, changes7.patch, MCHANGES-66.zip, sax-parsing.patch
>
>
> The changelog plugin reads the contents of the changes.xml file and scatters \n characters into it. The attached patch fixes this and also improves performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-66) The changes plugin scatters white
space over its Changes report
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_119881 ]
Dennis Lundberg commented on MCHANGES-66:
-----------------------------------------
Benjamin, your patch removes *all* line breaks for me, was that intended?
I end up with all the contents of an element on one very long line, even though the sources.xml file has line breaks in it.
> The changes plugin scatters white space over its Changes report
> ---------------------------------------------------------------
>
> Key: MCHANGES-66
> URL: http://jira.codehaus.org/browse/MCHANGES-66
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Reporter: Henning Schmiedehausen
> Assignee: Dennis Lundberg
> Attachments: changes-report.html, changes.xml, changes4.patch, changes7.patch, MCHANGES-66.zip, sax-parsing.patch
>
>
> The changelog plugin reads the contents of the changes.xml file and scatters \n characters into it. The attached patch fixes this and also improves performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHANGES-66) The changes plugin scatters white
space over its Changes report
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg updated MCHANGES-66:
------------------------------------
Attachment: MCHANGES-66.zip
Thanks for the changes-file Benjamin. I tried it using both 2.0-beta-3 and the latest 2.0-beta-4-SNAPSHOT and I don't see any scattered whitespace. All the lines in the generated html report are of equal length. Please try it yourself with the attached project.
> The changes plugin scatters white space over its Changes report
> ---------------------------------------------------------------
>
> Key: MCHANGES-66
> URL: http://jira.codehaus.org/browse/MCHANGES-66
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Reporter: Henning Schmiedehausen
> Assignee: Dennis Lundberg
> Attachments: changes.xml, changes4.patch, changes7.patch, MCHANGES-66.zip, sax-parsing.patch
>
>
> The changelog plugin reads the contents of the changes.xml file and scatters \n characters into it. The attached patch fixes this and also improves performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHANGES-66) The changes plugin scatters white
space over its Changes report
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg updated MCHANGES-66:
------------------------------------
Component/s: changes-report
> The changes plugin scatters white space over its Changes report
> ---------------------------------------------------------------
>
> Key: MCHANGES-66
> URL: http://jira.codehaus.org/browse/MCHANGES-66
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Reporter: Henning Schmiedehausen
> Assignee: Stephane Nicoll
> Attachments: changes4.patch, changes7.patch
>
>
> The changelog plugin reads the contents of the changes.xml file and scatters \n characters into it. The attached patch fixes this and also improves performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-66) The changes plugin scatters white
space over its Changes report
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101645 ]
Dennis Lundberg commented on MCHANGES-66:
-----------------------------------------
Henning, can you supply a changes.xml file that highlights this problem?
Also, I'm wondering where the scattered '\n' characters turn up. Is it in the announcement, like it is for Stephane, or is it somewhere else?
> The changes plugin scatters white space over its Changes report
> ---------------------------------------------------------------
>
> Key: MCHANGES-66
> URL: http://jira.codehaus.org/browse/MCHANGES-66
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Reporter: Henning Schmiedehausen
> Assignee: Stephane Nicoll
> Attachments: changes4.patch, changes7.patch
>
>
> The changelog plugin reads the contents of the changes.xml file and scatters \n characters into it. The attached patch fixes this and also improves performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-66) The changes plugin scatters white
space over its Changes report
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_120844 ]
Benjamin Bentmann commented on MCHANGES-66:
-------------------------------------------
bq. 51 weeks and one day after the initial bug report, a new snapshot has been deployed.
Henning, how many weeks have passed since Dennis asked you to provide a changes.xml to nail the issue down? I guess you had something better to do, just like the committers. This issue has just one vote and there are lots of other, higher voted issues waiting to be investigated and solved.
> The changes plugin scatters white space over its Changes report
> ---------------------------------------------------------------
>
> Key: MCHANGES-66
> URL: http://jira.codehaus.org/browse/MCHANGES-66
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Reporter: Henning Schmiedehausen
> Assignee: Dennis Lundberg
> Fix For: 2.0-beta-4
>
> Attachments: changes-report.html, changes.xml, changes4.patch, changes7.patch, MCHANGES-66.zip, sax-parsing.patch
>
>
> The changelog plugin reads the contents of the changes.xml file and scatters \n characters into it. The attached patch fixes this and also improves performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira