[GitHub] kafka pull request #4214: MINOR: Make PushHttpMetricsReporter API compatible...

[ewencp <gi...@git.apache.org>]

GitHub user ewencp opened a pull request:

    https://github.com/apache/kafka/pull/4214

    MINOR: Make PushHttpMetricsReporter API compatible with releases back to 0.8.2.2

    This is follow up to #4072 which added the PushHttpMetricsReporter and converted some services to use it. We somehow missed some compatibility issues that made the ProducerPerformance tool fail when using a newer tools jar with older common/clients jar, which we do with some system tests so we have all the features we need in the tool but can build compatibility tests for older releases.
    
    This just adjusts some API usage to make the tool compatible with all previous releases.
    
    I have a full run of the tests starting [here](https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1122/)
    
    ### Committer Checklist (excluded from commit message)
    - [ ] Verify design and implementation 
    - [ ] Verify test coverage and CI build status
    - [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ewencp/kafka fix-compatibility-sanity-check-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4214
    
----
commit 4298e150e24adecb878ea35cec40ff688c9379d3
Author: Ewen Cheslack-Postava <me...@ewencp.org>
Date:   2017-11-15T01:31:24Z

    MINOR: Make PushHttpMetricsReporter API compatible with releases back to 0.8.2.2

----


---

[GitHub] kafka pull request #4214: MINOR: Make PushHttpMetricsReporter API compatible...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/4214


---