You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/02/06 06:41:47 UTC

[kudu-CR](branch-1.9.x) Bump version to 1.9.0 (non-SNAPSHOT)

Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12382


Change subject: Bump version to 1.9.0 (non-SNAPSHOT)
......................................................................

Bump version to 1.9.0 (non-SNAPSHOT)

Change-Id: I91d84f268504ad42790f09ef843154bf1ab25d56
---
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
M version.txt
2 files changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/12382/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91d84f268504ad42790f09ef843154bf1ab25d56
Gerrit-Change-Number: 12382
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>

[kudu-CR](branch-1.9.x) Bump version to 1.9.0 (non-SNAPSHOT)

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12382 )

Change subject: Bump version to 1.9.0 (non-SNAPSHOT)
......................................................................


Patch Set 2:

Bummer, this failure looks like a setup.py bug. I will try to fix it.


-- 
To view, visit http://gerrit.cloudera.org:8080/12382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d84f268504ad42790f09ef843154bf1ab25d56
Gerrit-Change-Number: 12382
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Feb 2019 14:32:44 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.9.x) Bump version to 1.9.0 (non-SNAPSHOT)

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12382

to look at the new patch set (#3).

Change subject: Bump version to 1.9.0 (non-SNAPSHOT)
......................................................................

Bump version to 1.9.0 (non-SNAPSHOT)

Also included is a tweak to setup.py to correctly handle non-SNAPSHOT
verions. A separate patch will go in on master.

Change-Id: I91d84f268504ad42790f09ef843154bf1ab25d56
---
M python/setup.py
M version.txt
2 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/12382/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91d84f268504ad42790f09ef843154bf1ab25d56
Gerrit-Change-Number: 12382
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.9.x) Bump version to 1.9.0 (non-SNAPSHOT)

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12382 )

Change subject: Bump version to 1.9.0 (non-SNAPSHOT)
......................................................................

Bump version to 1.9.0 (non-SNAPSHOT)

Also included is a tweak to setup.py to correctly handle non-SNAPSHOT
verions. A separate patch will go in on master.

Change-Id: I91d84f268504ad42790f09ef843154bf1ab25d56
Reviewed-on: http://gerrit.cloudera.org:8080/12382
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M python/setup.py
M version.txt
2 files changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I91d84f268504ad42790f09ef843154bf1ab25d56
Gerrit-Change-Number: 12382
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.9.x) Bump version to 1.9.0 (non-SNAPSHOT)

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12382 )

Change subject: Bump version to 1.9.0 (non-SNAPSHOT)
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d84f268504ad42790f09ef843154bf1ab25d56
Gerrit-Change-Number: 12382
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Feb 2019 17:16:05 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.9.x) Bump version to 1.9.0 (non-SNAPSHOT)

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12382 )

Change subject: Bump version to 1.9.0 (non-SNAPSHOT)
......................................................................


Patch Set 2:

I think changing the failing line in setup.py to this should work:
   ```label = version_match.group("label")
        if label is not None and "SNAPSHOT" in label:```

Do you want to include that change in this patch and then do a separate patch for master?


-- 
To view, visit http://gerrit.cloudera.org:8080/12382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d84f268504ad42790f09ef843154bf1ab25d56
Gerrit-Change-Number: 12382
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Feb 2019 14:36:10 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.9.x) Bump version to 1.9.0 (non-SNAPSHOT)

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12382 )

Change subject: Bump version to 1.9.0 (non-SNAPSHOT)
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d84f268504ad42790f09ef843154bf1ab25d56
Gerrit-Change-Number: 12382
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Feb 2019 14:23:33 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.9.x) Bump version to 1.9.0 (non-SNAPSHOT)

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12382 )

Change subject: Bump version to 1.9.0 (non-SNAPSHOT)
......................................................................


Patch Set 3:

> Patch Set 2:
> 
> I think changing the failing line in setup.py to this should work:
>    ```label = version_match.group("label")
>         if label is not None and "SNAPSHOT" in label:```
> 
> Do you want to include that change in this patch and then do a separate patch for master?

Done, yep will put up the patch on master.


-- 
To view, visit http://gerrit.cloudera.org:8080/12382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d84f268504ad42790f09ef843154bf1ab25d56
Gerrit-Change-Number: 12382
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Feb 2019 17:10:45 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.9.x) Bump version to 1.9.0 (non-SNAPSHOT)

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12382

to look at the new patch set (#2).

Change subject: Bump version to 1.9.0 (non-SNAPSHOT)
......................................................................

Bump version to 1.9.0 (non-SNAPSHOT)

Change-Id: I91d84f268504ad42790f09ef843154bf1ab25d56
---
M version.txt
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/12382/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91d84f268504ad42790f09ef843154bf1ab25d56
Gerrit-Change-Number: 12382
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.9.x) Bump version to 1.9.0 (non-SNAPSHOT)

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12382 )

Change subject: Bump version to 1.9.0 (non-SNAPSHOT)
......................................................................


Patch Set 2:

Actually don't think I need to change the Java test...


-- 
To view, visit http://gerrit.cloudera.org:8080/12382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d84f268504ad42790f09ef843154bf1ab25d56
Gerrit-Change-Number: 12382
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Feb 2019 07:11:21 +0000
Gerrit-HasComments: No